Mercurial > repos > public > sbplib_julia
diff test/SbpOperators/boundaryops/normal_derivative_test.jl @ 950:97e9a8337a86 feature/laplace_opset
Review: broadcast instead of map in some places
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Mon, 14 Mar 2022 08:06:50 +0100 |
| parents | 7168d28b03e3 |
| children | 775d5513da8f |
line wrap: on
line diff
--- a/test/SbpOperators/boundaryops/normal_derivative_test.jl Mon Mar 14 08:03:40 2022 +0100 +++ b/test/SbpOperators/boundaryops/normal_derivative_test.jl Mon Mar 14 08:06:50 2022 +0100 @@ -42,6 +42,9 @@ d_closure = parse_stencil(stencil_set["d1"]["closure"]) d_w, d_e, d_s, d_n = map(id -> normal_derivative(g_2D, d_closure, id), boundary_identifiers(g_2D)) + # REVIEW: Would prefere to write this as + # d_w, d_e, d_s, d_n = normal_derivative.(Ref(g_2D), Ref(d_closure), boundary_identifiers(g_2D)) + # to avoid the line break @test d_w*v ≈ -v∂x[1,:] atol = 1e-13 @test d_e*v ≈ v∂x[end,:] atol = 1e-13 @@ -54,7 +57,7 @@ d_closure = parse_stencil(stencil_set["d1"]["closure"]) d_w, d_e, d_s, d_n = map(id -> normal_derivative(g_2D, d_closure, id), boundary_identifiers(g_2D)) - + # REVIEW: Same as above @test d_w*v ≈ -v∂x[1,:] atol = 1e-13 @test d_e*v ≈ v∂x[end,:] atol = 1e-13 @test d_s*v ≈ -v∂y[:,1] atol = 1e-13