Mercurial > repos > public > sbplib_julia
annotate TODO.md @ 542:011ca1639153 refactor/tensor_index_coupling
Remove Index{Unknown} and replace with general Any implementations
author | Jonatan Werpers <jonatan@werpers.com> |
---|---|
date | Fri, 27 Nov 2020 11:27:37 +0100 |
parents | 7e698030c170 |
children | ace46ca8513f |
rev | line source |
---|---|
102 | 1 # TODO |
2 | |
294 | 3 ## Skämskudde |
4 - [ ] Ändra namn på variabler och funktioner så att det följer style-guide | |
5 - [ ] Skriv tester | |
102 | 6 |
294 | 7 ## Coding |
297
dfadc0bafbbd
Fix some formatting errors in TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents:
295
diff
changeset
|
8 - [ ] Add new Laplace opertor to DiffOps, probably named WaveEqOp(?!!?) |
294 | 9 - [ ] Add 1D operators (D1, D2, e, d ... ) as TensorOperators |
10 - [ ] Create a struct that bundles the necessary Tensor operators for solving the wave equation. | |
320
d705b397aa33
Clean up Notes.md and TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents:
319
diff
changeset
|
11 - [ ] Add a quick and simple way of running all tests for all subpackages. |
379
de4746d6d126
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
332
diff
changeset
|
12 - [ ] Replace getindex hack for flatteing tuples with flatten_tuple. |
427
1c41f4fd3e61
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
379
diff
changeset
|
13 - [ ] Fix indexing signatures. We should make sure we are not too specific. For the "inbetween" layers we don't know what type of index is coming so we should use `I...` instead of `I::Vararg{Int,R}` or probably better `I::Vararg{Any,R}` |
379
de4746d6d126
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
332
diff
changeset
|
14 - [ ] Use `@inferred` in a lot of tests. |
427
1c41f4fd3e61
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
379
diff
changeset
|
15 - [ ] Make sure we are setting tolerances in tests in a consistent way |
490 | 16 - [ ] Add check for correct domain sizes to lazy tensor operations using SizeMismatch |
542
011ca1639153
Remove Index{Unknown} and replace with general Any implementations
Jonatan Werpers <jonatan@werpers.com>
parents:
490
diff
changeset
|
17 - [ ] Write down some coding guideline or checklist for code convetions. For example i,j,... för indecies and I for multi-index |
119 | 18 |
379
de4746d6d126
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
332
diff
changeset
|
19 ## Repo |
332
535f1bff4bcc
Add some notes and some todos
Jonatan Werpers <jonatan@werpers.com>
parents:
320
diff
changeset
|
20 - [ ] Add Vidar to the authors list |
379
de4746d6d126
Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents:
332
diff
changeset
|
21 - [ ] Rename repo to Sbplib.jl |
297
dfadc0bafbbd
Fix some formatting errors in TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents:
295
diff
changeset
|
22 |
320
d705b397aa33
Clean up Notes.md and TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents:
319
diff
changeset
|
23 # Wrap up tasks |
294 | 24 - [ ] Kolla att vi har @inbounds och @propagate_inbounds på rätt ställen |
25 - [ ] Kolla att vi gör boundschecks överallt och att de är markerade med @boundscheck | |
26 - [ ] Kolla att vi har @inline på rätt ställen | |
27 - [ ] Profilera | |
145
e0c8f5cf3a3f
Rename boundary indentifiers and use them inte the sat functions
Jonatan Werpers <jonatan@werpers.com>
parents:
119
diff
changeset
|
28 |
265
4308b500d6e7
Add ideas to TODO.txt
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
145
diff
changeset
|
29 |
294 | 30 # Old stuff todos (Are these still relevant?) |
274
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
31 Borde det finns motsvarande apply_stencil för apply_quadrature, |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
32 apply_boundary_value och apply_normal_derivative? |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
33 |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
34 Borde man alltid skicka in N som parameter i apply_2nd_derivative, t.ex som i |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
35 apply_quadrature? |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
36 |
11010bb74260
Dispatch getindex for TensorMappingApplication on region indices. Dispatch apply
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents:
265
diff
changeset
|
37 Just nu agerar apply_normal_derivative, apply_boundary_value på inte på v som |
320
d705b397aa33
Clean up Notes.md and TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents:
319
diff
changeset
|
38 en vektor, utan randvärdet plockas ut utanför. Känns inte konsistent med övrig design. |