Mercurial > repos > public > sbplib_julia
changeset 320:d705b397aa33
Clean up Notes.md and TODO.md
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Thu, 10 Sep 2020 11:03:22 +0200 |
| parents | 05ac7d7f9176 |
| children | 277dff5b071a |
| files | Notes.md TODO.md |
| diffstat | 2 files changed, 7 insertions(+), 13 deletions(-) [+] |
line wrap: on
line diff
--- a/Notes.md Thu Sep 10 10:56:31 2020 +0200 +++ b/Notes.md Thu Sep 10 11:03:22 2020 +0200 @@ -2,6 +2,10 @@ ## Known size of range and domain? It might be a good idea let tensormappings know the size of their range and domain as a constant. This probably can't be enforced on the abstract type but maybe we should write our difference operators this way. Having this as default should clean up the thinking around adjoints of boundary operators. It could also simplify getting high performance out of repeated application of regioned TensorMappings. +Is there any reason to use a trait to differentiate between fixed size and unknown size? + +## Test setup +Once we figure out how to organize the subpackages we should update test folders to Project. As of writing this there seems to be and issue with this approach combined with dev'ed packages so we can't do it yet. It seems that Pkg might fix this in the future. ## Reasearch and thinking - [ ] Use a trait to indicate if a TensorMapping uses indices with regions. @@ -15,7 +19,4 @@ - [ ] Formalize how range_size() and domain_size() are supposed to work in TensorMappings where dim(domain) != dim(range) (add tests or document) - [ ] Create a macro @lazy which replaces a binary op (+,-) by its lazy equivalent? Would be a neat way to indicate which evaluations are lazy without cluttering/confusing with special characters. - [ ] Specificera operatorer i TOML eller något liknande? - - [x] Redo all Tensor applys to take Vararg instead of tuple of Index? - - [x] Should there be some kind of collection struct for SBP operators (as TensorOperators), providing easy access to all parts (D2, e, d , -> YES! H.. H_gamma etc.) - - [x] Is "missing" a good value for unknown dimension sizes (of `e*g` for example) \ No newline at end of file
--- a/TODO.md Thu Sep 10 10:56:31 2020 +0200 +++ b/TODO.md Thu Sep 10 11:03:22 2020 +0200 @@ -8,15 +8,10 @@ - [ ] Add new Laplace opertor to DiffOps, probably named WaveEqOp(?!!?) - [ ] Add 1D operators (D1, D2, e, d ... ) as TensorOperators - [ ] Create a struct that bundles the necessary Tensor operators for solving the wave equation. - - [ ] Use traits like IndexStyle, IndexLinear, IndexCartesian to differentiate - TensorMappings that are flexible in size and those that are fixed in size - - [ ] Use traits for symmetric tensor mappings such that apply_transpoe = apply for all such mappings - - [x] Move Laplace tensor operator to different package - - [x] Remove grid as a property of the Laplace tensor operator - - [ ] Update how dependencies are handled for tests. This was updated in Julia v1.2 and would allow us to use test specific dev packages. + - [ ] Add a quick and simple way of running all tests for all subpackages. -# Wrap up task +# Wrap up tasks - [ ] Kolla att vi har @inbounds och @propagate_inbounds på rätt ställen - [ ] Kolla att vi gör boundschecks överallt och att de är markerade med @boundscheck - [ ] Kolla att vi har @inline på rätt ställen @@ -31,6 +26,4 @@ apply_quadrature? Just nu agerar apply_normal_derivative, apply_boundary_value på inte på v som -en vektor, utan randvärdet plockas ut utanför. Känns inte konsistent med övrig -design - +en vektor, utan randvärdet plockas ut utanför. Känns inte konsistent med övrig design.