Mercurial > repos > public > sbplib_julia
changeset 1600:b2496b001297 feature/boundary_conditions
REVIEW: Forgot to save...
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Wed, 29 May 2024 22:44:18 +0200 |
| parents | 37b05221beda |
| children | fad18896d20a |
| files | src/SbpOperators/volumeops/laplace/laplace.jl |
| diffstat | 1 files changed, 4 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/SbpOperators/volumeops/laplace/laplace.jl Wed May 29 22:35:08 2024 +0200 +++ b/src/SbpOperators/volumeops/laplace/laplace.jl Wed May 29 22:44:18 2024 +0200 @@ -53,6 +53,8 @@ end laplace(g::EquidistantGrid, stencil_set) = second_derivative(g, stencil_set) +# REVIEW: I think the handling of tuning parameters below should be through kwargs instead. + """ sat_tensors(Δ::Laplace, g::Grid, bc::DirichletCondition, tuning) @@ -72,7 +74,7 @@ sat_op = H⁻¹∘(d' - B*e')∘Hᵧ return sat_op, e end -BoundaryConditions.sat_tensors(Δ::Laplace, g::Grid, bc::DirichletCondition) = BoundaryConditions.sat_tensors(Δ, g, bc, (1.,1.)) +BoundaryConditions.sat_tensors(Δ::Laplace, g::Grid, bc::DirichletCondition) = BoundaryConditions.sat_tensors(Δ, g, bc, (1.,1.)) # REVIEW: Should be possible to replace this with argument default values. """ sat_tensors(Δ::Laplace, g::Grid, bc::NeumannCondition) @@ -94,6 +96,7 @@ return sat_op, d end +# REVIEW: This function assumes a TensorGrid right? In that case there should probably be a type annotation to get clearer error messages. function positivity_decomposition(Δ::Laplace, g::Grid, bc::DirichletCondition, tuning) pos_prop = positivity_properties(Δ) h = spacing(orthogonal_grid(g, bc.id))