Mercurial > repos > public > sbplib_julia
changeset 1806:f21bfc5f21aa feature/grids/curvilinear
Address review comment by adding TODO
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Wed, 02 Oct 2024 20:58:07 +0200 |
| parents | 0c705f0bb3a9 |
| children | ef09897bc00f |
| files | src/Grids/mapped_grid.jl |
| diffstat | 1 files changed, 2 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl Wed Oct 02 20:57:40 2024 +0200 +++ b/src/Grids/mapped_grid.jl Wed Oct 02 20:58:07 2024 +0200 @@ -170,12 +170,11 @@ The outward pointing normal as a grid function on the corresponding boundary grid. """ -# Review: I guess there is no clean way of calling normal(g::MappedGrid, boundary, i...) -# here? Something along return map(i -> normal(g, boundary, i), boundary_indices(g, boundary)) -# If there is I think it would be cleaner. Otherwise, keep as it. function normal(g::MappedGrid, boundary) b_indices = boundary_indices(g, boundary) σ = _boundary_sign(component_type(g), boundary) + + # TODO: Refactor this when `boundary_indices(g, ...)` has been made iterable. return map(jacobian(g)[b_indices...]) do ∂x∂ξ ∂ξ∂x = inv(∂x∂ξ) k = grid_id(boundary)