Mercurial > repos > public > sbplib_julia
changeset 1644:e213bd857f3f feature/grids/manifolds
Add some todos and tbds
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Wed, 26 Jun 2024 11:06:32 +0200 |
| parents | 35f8e1adb010 |
| children | 8250cf5a3ce9 |
| files | src/Grids/equidistant_grid.jl src/Grids/grid.jl src/Grids/manifolds.jl |
| diffstat | 3 files changed, 8 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/Grids/equidistant_grid.jl Mon Jun 24 21:36:27 2024 +0200 +++ b/src/Grids/equidistant_grid.jl Wed Jun 26 11:06:32 2024 +0200 @@ -129,6 +129,7 @@ equidistant_grid(hb::HyperBox, dims::Vararg{Int}) = equidistant_grid(hb.a, hb.b, dims...) +# TODO: One dimensional grids shouldn't have vector eltype right?, Change here or in HyperBox? function equidistant_grid(c::Chart, dims::Vararg{Int}) lg = equidistant_grid(parameterspace(c), dims...)
--- a/src/Grids/grid.jl Mon Jun 24 21:36:27 2024 +0200 +++ b/src/Grids/grid.jl Wed Jun 26 11:06:32 2024 +0200 @@ -107,6 +107,8 @@ """ function boundary_identifiers end +# TBD: Boundary identifiers for charts and atlases? + """ boundary_grid(g::Grid, id::BoundaryIdentifier)
--- a/src/Grids/manifolds.jl Mon Jun 24 21:36:27 2024 +0200 +++ b/src/Grids/manifolds.jl Wed Jun 26 11:06:32 2024 +0200 @@ -19,6 +19,7 @@ """ abstract type ParameterSpace{D} end Base.ndims(::ParameterSpace{D}) where D = D +# TBD: Should implement domain_dim? struct HyperBox{T,D} <: ParameterSpace{D} a::SVector{D,T} @@ -98,8 +99,11 @@ which will both allow calling `jacobian(c,ξ)`. """ jacobian(c::Chart, ξ) = jacobian(c.mapping, ξ) +# TBD: Can we register a error hint for when jacobian is called with a function that doesn't have a registered jacobian? +# TBD: Should Charts, parameterspaces have boundary names? + """ Atlas @@ -199,4 +203,5 @@ s(ξ̄...) end +# TODO: Implement jacobian() for the different mapping helpers