changeset 1615:b74e1a21265f feature/boundary_conditions

Add todos to test
author Vidar Stiernström <vidar.stiernstrom@gmail.com>
date Sun, 09 Jun 2024 17:04:01 -0700
parents 13063028d604
children e41eddc640f3
files test/SbpOperators/volumeops/laplace/laplace_test.jl
diffstat 1 files changed, 9 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/test/SbpOperators/volumeops/laplace/laplace_test.jl	Sun Jun 09 16:53:03 2024 -0700
+++ b/test/SbpOperators/volumeops/laplace/laplace_test.jl	Sun Jun 09 17:04:01 2024 -0700
@@ -89,13 +89,21 @@
 end
 
 @testset "sat_tensors" begin
+    # TODO: The following tests should be implemented
+    #       1. Symmetry D'H == H'D (test_broken below)
+    #       2. Test eigenvalues of and/or solution to Poisson
+    #       3. Test tuning of Dirichlet conditions
+    #
+    #       These tests are likely easiest to implement once
+    #       we have support for generating matrices from tensors.
+
     operator_path = sbp_operators_path()*"standard_diagonal.toml"
     orders = (2,4)
     tols = (5e-2,5e-4)
     sz = (201,401)
     g = equidistant_grid((0.,0.), (1.,1.), sz...)
     
-    # Verify implementation of sat_tesnors by testing accuracy and symmetry (TODO) 
+    # Verify implementation of sat_tensors by testing accuracy and symmetry (TODO) 
     # of the operator D = Δ + SAT, where SAT is the tensor composition of the 
     # operators from sat_tensor. Note that SAT*u should approximate 0 for the 
     # conditions chosen.
@@ -115,7 +123,6 @@
             # Accuracy
             @test sqrt(sum(H*e.^2)) ≈ 0 atol = tol
             # Symmetry
-            # TODO: # Consider generating the matrices to H and D and test D'H == H'D
             r = randn(size(u))
             @test_broken (D'∘H - H∘D)*r .≈ 0 atol = 1e-13 # TODO: Need to implement apply_transpose for D.
         end
@@ -137,7 +144,6 @@
                 # Accuracy
                 @test sqrt(sum(H*e.^2)) ≈ 0 atol = tol
                 # Symmetry
-                # TODO: # Consider generating the matrices to H and D and test D'H == H'D
                 r = randn(size(u))
                 @test_broken (D'∘H - H∘D)*r .≈ 0 atol = 1e-13 # TODO: Need to implement apply_transpose for D.
             end