Mercurial > repos > public > sbplib_julia

changeset 1434:af73340a8f0e feature/grids/curvilinear

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add todos
author Jonatan Werpers <jonatan@werpers.com>
date Thu, 07 Sep 2023 09:03:07 +0200
parents 1656228095b5
children 29adc06e5b56
files src/Grids/Grids.jl src/Grids/tensor_grid.jl test/Grids/curvilinear_grid_test.jl
diffstat 3 files changed, 10 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/Grids.jl	Mon Aug 28 09:38:15 2023 +0200
+++ b/src/Grids/Grids.jl	Thu Sep 07 09:03:07 2023 +0200
@@ -1,3 +1,4 @@
+# TODO: Double check that the interfaces for indexing and iterating are fully implemented and tested for all grids.
 module Grids
 
 using Sbplib.RegionIndices
--- a/src/Grids/tensor_grid.jl	Mon Aug 28 09:38:15 2023 +0200
+++ b/src/Grids/tensor_grid.jl	Thu Sep 07 09:03:07 2023 +0200
@@ -1,3 +1,5 @@
+# TODO: Check this file and other grids for duplicate implementation of general methods implemented for Grid
+
 """
     TensorGrid{T,D} <: Grid{T,D}
 
--- a/test/Grids/curvilinear_grid_test.jl	Mon Aug 28 09:38:15 2023 +0200
+++ b/test/Grids/curvilinear_grid_test.jl	Thu Sep 07 09:03:07 2023 +0200
@@ -3,11 +3,17 @@
 using StaticArrays
 
 @testset "CurvilinearGrid" begin
-    lg = equidistant_grid((11,11), (0,0), (1,1))
+    lg = equidistant_grid((11,11), (0,0), (1,1)) # TODO: Change dims of the grid to be different
     x̄ = map(ξ̄ -> 2ξ̄, lg)
     J = map(ξ̄ -> @SArray(fill(2., 2, 2)), lg)
     cg = CurvilinearGrid(lg, x̄, J)
 
+    # TODO: Test constructor for different dims of range and domain for the coordinates
+    # TODO: Test constructor with different type than TensorGrid. a dummy type?
+
+    @test_broken false # @test_throws ArgumentError("Sizes must match") CurvilinearGrid(lg, map(ξ̄ -> @SArray[ξ̄[1], ξ̄[2], -ξ̄[1]], lg), rand(SMatrix{2,3,Float64},15,11))
+
+
     @test cg isa Grid{SVector{2, Float64},2}
 
     @test jacobian(cg) isa Array{<:AbstractMatrix}