Mercurial > repos > public > sbplib_julia
changeset 1490:a7689021d4c2 feature/grids/componentview
REVIEW: Add review comments to tests
author | Vidar Stiernström <vidar.stiernstrom@it.uu.se> |
---|---|
date | Sat, 30 Dec 2023 13:33:17 +0100 |
parents | 62f9d0387a2a |
children | 06dec7b68f82 |
files | test/Grids/grid_test.jl |
diffstat | 1 files changed, 3 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/test/Grids/grid_test.jl Fri Dec 01 14:58:05 2023 +0100 +++ b/test/Grids/grid_test.jl Sat Dec 30 13:33:17 2023 +0100 @@ -64,6 +64,7 @@ end @testset "componentview" begin + # REVIEW: I think we can reduce the index ranges. v = [@SMatrix[1 3; 2 4] .+ 100*i .+ 10*j for i ∈ 1:3, j∈ 1:4] @test componentview(v, 1, 1) == [1 .+ 100*i .+ 10*j for i ∈ 1:3, j∈ 1:4] @@ -89,8 +90,9 @@ @testset "ArrayComponentView" begin v = [@SMatrix[1 3; 2 4] .+ 100*i .+ 10*j for i ∈ 1:3, j∈ 1:4] - @test ArrayComponentView(v, (1,1)) == ArrayComponentView(v, (1,1)) + @test ArrayComponentView(v, (1,1)) == ArrayComponentView(v, (1,1)) # REVIEW: Does not test anything? @test ArrayComponentView(v, (1,1)) == ArrayComponentView(copy(v), (1,1)) + # REVIEW: The two below are equivalent? @test ArrayComponentView(v, (1,1)) == [1 .+ 100*i .+ 10*j for i ∈ 1:3, j∈ 1:4] @test [1 .+ 100*i .+ 10*j for i ∈ 1:3, j∈ 1:4] == ArrayComponentView(v, (1,1)) end