Mercurial > repos > public > sbplib_julia

changeset 812:8c977b336803 operator_storage_array_of_table

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review: Suggested changes in constant_interior_scaling_operator.jl
author Vidar Stiernström <vidar.stiernstrom@it.uu.se>
date Wed, 22 Sep 2021 13:09:17 +0200
parents 6f9ae8932d09
children cdc2b5ebf7cb
files src/SbpOperators/volumeops/constant_interior_scaling_operator.jl
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/SbpOperators/volumeops/constant_interior_scaling_operator.jl	Tue Sep 21 13:33:27 2021 +0200
+++ b/src/SbpOperators/volumeops/constant_interior_scaling_operator.jl	Wed Sep 22 13:09:17 2021 +0200
@@ -10,6 +10,9 @@
     size::Int
 
     function ConstantInteriorScalingOperator(interior_weight::T, closure_weights::NTuple{N,T}, size::Int) where {T,N}
+        # Review: Suggested change
+        # 2length(closure_weights) --> 2*length(closure_weights)
+        # Excluding the multiplication makes in look like a typo.
         if size < 2length(closure_weights)
             throw(DomainError(size, "size must be larger that two times the closure size."))
         end