Mercurial > repos > public > sbplib_julia

changeset 1828:8adecef380b4 refactor/grids/iterable_boundary_indices

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add some todos
author Jonatan Werpers <jonatan@werpers.com>
date Tue, 17 Sep 2024 11:20:00 +0200
parents ab397590898e
children 871f3f1decea
files src/Grids/tensor_grid.jl test/Grids/tensor_grid_test.jl
diffstat 2 files changed, 2 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/tensor_grid.jl	Tue Sep 17 11:19:08 2024 +0200
+++ b/src/Grids/tensor_grid.jl	Tue Sep 17 11:20:00 2024 +0200
@@ -97,6 +97,7 @@
 
     return view(_combine_indices(all_indices...), LazyTensors.concatenate_tuples(bla.(b_ind)...)...)
 end
+# TODO: There must be a way to make the above code cleaner?
 
 # function _combine_indices(Is::Vararg{Union{Int, <:AbstractRange}})
 function _combine_indices(Is...)
--- a/test/Grids/tensor_grid_test.jl	Tue Sep 17 11:19:08 2024 +0200
+++ b/test/Grids/tensor_grid_test.jl	Tue Sep 17 11:20:00 2024 +0200
@@ -196,6 +196,7 @@
         @test collect(boundary_indices(TensorGrid(g₁, g₄), TensorGridBoundary{1, Upper}())) == fill(11)
         @test collect(boundary_indices(TensorGrid(g₄,g₁), TensorGridBoundary{2, Lower}())) == fill(1)
         @test collect(boundary_indices(TensorGrid(g₄,g₁), TensorGridBoundary{2, Upper}())) == fill(11)
+        # TBD: What do we actually expect for 1D grids?
     end
 end