Mercurial > repos > public > sbplib_julia
changeset 872:6a4d36eccf39 feature/laplace_opset
REVIEW: Add some comments about the tests
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Tue, 25 Jan 2022 10:36:13 +0100 |
| parents | 86776d06b883 |
| children | 067a322e4f73 0bf5952c240d |
| files | test/SbpOperators/volumeops/laplace/laplace_test.jl |
| diffstat | 1 files changed, 12 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/test/SbpOperators/volumeops/laplace/laplace_test.jl Tue Jan 25 08:19:02 2022 +0100 +++ b/test/SbpOperators/volumeops/laplace/laplace_test.jl Tue Jan 25 10:36:13 2022 +0100 @@ -44,6 +44,17 @@ @test L == Laplace(Δ, H, Hi, e_dict, d_dict, Hb_dict) @test L isa TensorMapping{T,1,1} where T @inferred Laplace(Δ, H, Hi, e_dict, d_dict, Hb_dict) + # REVIEW: The tests above seem very tied to the implementation. Is + # it important that the components of the operator set are stored + # in static dicts? Is something like below better? + # + # ``` + # L = Laplace(g_1D, operator_path; order=4) + # @test L isa TensorMapping{T,1,1} where T + # @test boundary_restriction(L,id_l) == boundary_restriction(g_1D, e_closure,id_l) + # ... + # ``` + # I guess this is more or less simply a reorganization of the test and skipping testing for the struct layout end @testset "3D" begin Δ = laplace(g_3D, inner_stencil, closure_stencils) @@ -88,6 +99,7 @@ end end + # REVIEW: Is this testset misplaced? Should it really be inside the "Laplace" testset? @testset "laplace" begin @testset "1D" begin L = laplace(g_1D, inner_stencil, closure_stencils)