changeset 951:66e8faf4bb4b feature/laplace_opset

Reviwe: Some more comments
author Jonatan Werpers <jonatan@werpers.com>
date Mon, 14 Mar 2022 08:25:11 +0100
parents 97e9a8337a86
children 6a8d7fbf55fc
files src/SbpOperators/SbpOperators.jl src/SbpOperators/volumeops/laplace/laplace.jl
diffstat 2 files changed, 4 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/SbpOperators/SbpOperators.jl	Mon Mar 14 08:06:50 2022 +0100
+++ b/src/SbpOperators/SbpOperators.jl	Mon Mar 14 08:25:11 2022 +0100
@@ -30,5 +30,7 @@
 export laplace
 export normal_derivative
 export second_derivative
+# REVIEW: Should the exports be placed here or at the top of each file where the thing is defined?
+# We currently have a mix of placing it at the place of definition and at the top of each file. This is a "new" way of doing it.
 
 end # module
--- a/src/SbpOperators/volumeops/laplace/laplace.jl	Mon Mar 14 08:06:50 2022 +0100
+++ b/src/SbpOperators/volumeops/laplace/laplace.jl	Mon Mar 14 08:25:11 2022 +0100
@@ -6,7 +6,7 @@
 used to construct the `TensorMapping`.
 """
 struct Laplace{T, Dim, TM<:TensorMapping{T, Dim, Dim}} <: TensorMapping{T, Dim, Dim}
-    D::TM# Differential operator
+    D::TM       # Difference operator
     stencil_set # Stencil set of the operator
 end
 
@@ -52,3 +52,4 @@
     end
     return Δ
 end
+# REVIEW: Do we need this method? Couldn't it just be inlined in the constructor on :19?