Mercurial > repos > public > sbplib_julia

changeset 963:52a0ebad0778 feature/laplace_opset

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review: Address review comment on placement of exports. Export statements should be placed at the top of the module file. Add todo.
author Vidar Stiernström <vidar.stiernstrom@it.uu.se>
date Mon, 14 Mar 2022 10:16:03 +0100
parents 1bb28e47990f
children 2ae62dbaf839
files TODO.md src/SbpOperators/SbpOperators.jl
diffstat 2 files changed, 10 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/TODO.md	Mon Mar 14 10:00:25 2022 +0100
+++ b/TODO.md	Mon Mar 14 10:16:03 2022 +0100
@@ -23,6 +23,7 @@
  - [ ] Add possibility to create tensor mapping application with `()`, e.g `D1(v) <=> D1*v`?
  - [ ] Add custom pretty printing to LazyTensors/SbpOperators to enhance readability of e.g error messages.
        See (https://docs.julialang.org/en/v1/manual/types/#man-custom-pretty-printing)
+ - [ ] Move export statements to top of each module
 
 ## Repo
  - [ ] Rename repo to Sbplib.jl
--- a/src/SbpOperators/SbpOperators.jl	Mon Mar 14 10:00:25 2022 +0100
+++ b/src/SbpOperators/SbpOperators.jl	Mon Mar 14 10:16:03 2022 +0100
@@ -1,5 +1,14 @@
 module SbpOperators
 
+export boundary_quadrature
+export boundary_restriction
+export inner_product
+export inverse_inner_product
+export Laplace
+export laplace
+export normal_derivative
+export second_derivative
+
 using Sbplib.RegionIndices
 using Sbplib.LazyTensors
 using Sbplib.Grids
@@ -21,16 +30,4 @@
 include("boundaryops/boundary_restriction.jl")
 include("boundaryops/normal_derivative.jl")
 
-
-export boundary_quadrature
-export boundary_restriction
-export inner_product
-export inverse_inner_product
-export Laplace
-export laplace
-export normal_derivative
-export second_derivative
-# REVIEW: Should the exports be placed here or at the top of each file where the thing is defined?
-# We currently have a mix of placing it at the place of definition and at the top of each file. This is a "new" way of doing it.
-
 end # module