Mercurial > repos > public > sbplib_julia
changeset 1156:50b008d2e937 refactor/grids
Remove comments about EquidistantGrid potentially being an AbstractArray
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Tue, 01 Nov 2022 22:37:10 +0100 |
| parents | bda0afcf8e52 |
| children | 93bba649aea2 |
| files | src/Grids/equidistant_grid.jl |
| diffstat | 1 files changed, 0 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/Grids/equidistant_grid.jl Thu Oct 20 20:59:56 2022 +0200 +++ b/src/Grids/equidistant_grid.jl Tue Nov 01 22:37:10 2022 +0100 @@ -35,9 +35,6 @@ function EquidistantGrid(size, limit_lower, limit_upper) return EquidistantGrid{length(size), eltype(limit_lower)}(size, limit_lower, limit_upper) end -# TBD: Should it be an AbstractArray? -# Review: Do we need it to be? It could be nice to have an iterator for a grid, but are there any other -# functionalities we need? Adding two grids etc? If not, I suggest against subtyping AbstractArray. """ EquidistantGrid{T}() @@ -70,8 +67,6 @@ end Base.getindex(g::EquidistantGrid, I::CartesianIndex) = g[Tuple(I)...] -# TBD: Can this method be removed if `EquidistantGrid` is an AbstractArray? -# Review: See comment above. # Review: # Is it not strange that evalOn(::Grid) is non-lazy while evalOn(::EquidistantGrid) is?