Mercurial > repos > public > sbplib_julia
changeset 1803:34ddb953a986 feature/grids/curvilinear
Review: Possible refactor of function normal?
| author | Vidar Stiernström <vidar.stiernstrom@gmail.com> |
|---|---|
| date | Wed, 02 Oct 2024 11:04:35 -0700 |
| parents | 8583f6379bd8 |
| children | 0c705f0bb3a9 |
| files | src/Grids/mapped_grid.jl |
| diffstat | 1 files changed, 3 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl Tue Oct 01 11:52:38 2024 +0200 +++ b/src/Grids/mapped_grid.jl Wed Oct 02 11:04:35 2024 -0700 @@ -170,6 +170,9 @@ The outward pointing normal as a grid function on the corresponding boundary grid. """ +# Review: I guess there is no clean way of calling normal(g::MappedGrid, boundary, i...) +# here? Something along return map(i -> normal(g, boundary, i), boundary_indices(g, boundary)) +# If there is I think it would be cleaner. Otherwise, keep as it. function normal(g::MappedGrid, boundary) b_indices = boundary_indices(g, boundary) σ = _boundary_sign(component_type(g), boundary)