Mercurial > repos > public > sbplib_julia

changeset 1745:2f7974367cd3 feature/grids/curvilinear

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add TBD
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 11 Sep 2024 14:11:11 +0200
parents c38eead8be17
children 44faa334adc6
files src/Grids/mapped_grid.jl test/Grids/mapped_grid_test.jl
diffstat 2 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl	Wed Sep 11 14:11:03 2024 +0200
+++ b/src/Grids/mapped_grid.jl	Wed Sep 11 14:11:11 2024 +0200
@@ -94,6 +94,7 @@
 # TBD: Should this be changed to calculate sqrt(g) instead?
 #       This would make it well defined also for n-dim grids embedded in higher dimensions.
 # TBD: Is there a better name? metric_determinant?
+# TBD: Is the best option to delete it?
 
 function metric_tensor(g::MappedGrid)
     return map(jacobian(g)) do ∂x∂ξ
--- a/test/Grids/mapped_grid_test.jl	Wed Sep 11 14:11:03 2024 +0200
+++ b/test/Grids/mapped_grid_test.jl	Wed Sep 11 14:11:11 2024 +0200
@@ -76,7 +76,6 @@
             rand(SMatrix{2,2},sz2...),
         )
 
-        # TODO: Test that the element types agree
         err_str = "The size of the jacobian must match the dimensions of the grid and coordinates"
         @test_throws ArgumentError(err_str) MappedGrid(
             equidistant_grid((0,0), (1,1), 10, 11),