Mercurial > repos > public > sbplib_julia

changeset 1776:265a740a49da feature/grids/curvilinear

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove reivew comment regarding implementation of normal since it requires more computation and we know of no other benefits
author Jonatan Werpers <jonatan@werpers.com>
date Sun, 15 Sep 2024 18:07:58 +0200
parents ecec2b0eea0f
children 819ab806960f ed1b43d07029
files src/Grids/mapped_grid.jl
diffstat 1 files changed, 0 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl	Sun Sep 15 18:05:57 2024 +0200
+++ b/src/Grids/mapped_grid.jl	Sun Sep 15 18:07:58 2024 +0200
@@ -178,18 +178,6 @@
     return ms
 end
 
-# Review: I would implement the normal through Nansons formula
-# nⱼ = inv(Jᵧ)*J*Fⱼᵢ*νᵢ
-# where 
-# Jᵧ  boundary jacobian determiant
-# J is the volume jacobian determinant
-# Fⱼᵢ = dξᵢ/dxⱼ
-# νᵢ normal on logical grid
-# j: indices on physical grid
-# i: indices on logical grid
-# ξ: coordinate vector on logical grid
-# x: coordinate vector on logical grid
-# Perhaps the below is equivalent?
 """
     normal(g::MappedGrid, boundary)