Mercurial > repos > public > sbplib_julia
changeset 922:0bf5952c240d feature/laplace_opset
Review: Add review comment regarding restructuring of Laplace
| author | Vidar Stiernström <vidar.stiernstrom@it.uu.se> |
|---|---|
| date | Sun, 30 Jan 2022 13:00:18 +0100 |
| parents | 6a4d36eccf39 |
| children | 88bf50821cf5 |
| files | src/SbpOperators/volumeops/laplace/laplace.jl |
| diffstat | 1 files changed, 6 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/SbpOperators/volumeops/laplace/laplace.jl Tue Jan 25 10:36:13 2022 +0100 +++ b/src/SbpOperators/volumeops/laplace/laplace.jl Sun Jan 30 13:00:18 2022 +0100 @@ -3,6 +3,12 @@ # REVIEW: Makes more sense to me to have the exports at the top of the file. # Might as well start fixing that. +# REVIEW: +# Design discussions has led to attempt a restructuring of Laplace to a more +# minimal type, holding the tensor mapping and a stencil set. This allows +# construction of associated tensor mappings, e.g. boundary operators, based on the +# stencil set while keeping the type simpler. + # REVIEW: The style of name `Laplace` might clash with other concepts. When # thinking about implementing the variable second derivative I think I will # have to create it as a full TM for the full dimensional problem instead of