Mercurial > repos > public > sbplib_julia
changeset 1158:c94a12327737 refactor/sbpoperators/inflation
Disregard review comments about multi-d tests.
After discussion on Discord we concluded that removing multi-d tests for volume operators would
make them too implementation dependent.
author | Jonatan Werpers <jonatan@werpers.com> |
---|---|
date | Tue, 29 Nov 2022 21:46:54 +0100 |
parents | 03c217c50d7c |
children | 25b1f408c165 |
files | test/LazyTensors/lazy_tensor_operations_test.jl test/SbpOperators/volumeops/derivatives/first_derivative_test.jl test/SbpOperators/volumeops/derivatives/second_derivative_test.jl |
diffstat | 3 files changed, 3 insertions(+), 8 deletions(-) [+] |
line wrap: on
line diff
diff -r 03c217c50d7c -r c94a12327737 test/LazyTensors/lazy_tensor_operations_test.jl --- a/test/LazyTensors/lazy_tensor_operations_test.jl Tue Nov 29 21:25:07 2022 +0100 +++ b/test/LazyTensors/lazy_tensor_operations_test.jl Tue Nov 29 21:46:54 2022 +0100 @@ -367,8 +367,6 @@ end end -# Review: If we are thorough in testing multi-D tensors here we can drop tests from many of the volume operators, -# e.g. first derivative and second derivative. @testset "inflate" begin I = LazyTensors.inflate(IdentityTensor(),(3,4,5,6), 2) @test I isa LazyTensor{Float64, 3,3}
diff -r 03c217c50d7c -r c94a12327737 test/SbpOperators/volumeops/derivatives/first_derivative_test.jl --- a/test/SbpOperators/volumeops/derivatives/first_derivative_test.jl Tue Nov 29 21:25:07 2022 +0100 +++ b/test/SbpOperators/volumeops/derivatives/first_derivative_test.jl Tue Nov 29 21:46:54 2022 +0100 @@ -19,9 +19,7 @@ end x^k/factorial(k) end -# Review: -# If we test LazyTensor.inflation for e.g 1D-3D general tensors then we should only need to test -# the 1D first derivative. + @testset "first_derivative" begin @testset "Constructors" begin stencil_set = read_stencil_set(sbp_operators_path()*"standard_diagonal.toml"; order=2)
diff -r 03c217c50d7c -r c94a12327737 test/SbpOperators/volumeops/derivatives/second_derivative_test.jl --- a/test/SbpOperators/volumeops/derivatives/second_derivative_test.jl Tue Nov 29 21:25:07 2022 +0100 +++ b/test/SbpOperators/volumeops/derivatives/second_derivative_test.jl Tue Nov 29 21:46:54 2022 +0100 @@ -6,9 +6,8 @@ import Sbplib.SbpOperators.VolumeOperator -# Review: -# If we test LazyTensor.inflation for e.g 1D-3D general tensors then we should only need to test -# the 1D second derivative. +# TODO: Refactor these test to look more like the tests in first_derivative_test.jl. + @testset "SecondDerivative" begin operator_path = sbp_operators_path()*"standard_diagonal.toml" stencil_set = read_stencil_set(operator_path; order=4)