changeset 1527:69790e9d1652 feature/grids/curvilinear

Remove tests for refine and coarsen
author Jonatan Werpers <jonatan@werpers.com>
date Tue, 09 Apr 2024 15:26:49 +0200
parents 4df668d00d03
children 9113f437431d
files src/Grids/mapped_grid.jl test/Grids/mapped_grid_test.jl
diffstat 2 files changed, 3 insertions(+), 19 deletions(-) [+]
line wrap: on
line diff
diff -r 4df668d00d03 -r 69790e9d1652 src/Grids/mapped_grid.jl
--- a/src/Grids/mapped_grid.jl	Tue Apr 09 07:58:27 2024 +0200
+++ b/src/Grids/mapped_grid.jl	Tue Apr 09 15:26:49 2024 +0200
@@ -48,6 +48,9 @@
     )
 end
 
+# TBD: refine and coarsen could be implemented once we have a simple manifold implementation.
+# Before we do, we should consider the overhead of including such a field in the mapped grid struct.
+
 function mapped_grid(x, J, size...)
     D = length(size)
     lg = equidistant_grid(size, ntuple(i->0., D), ntuple(i->1., D))
diff -r 4df668d00d03 -r 69790e9d1652 test/Grids/mapped_grid_test.jl
--- a/test/Grids/mapped_grid_test.jl	Tue Apr 09 07:58:27 2024 +0200
+++ b/test/Grids/mapped_grid_test.jl	Tue Apr 09 15:26:49 2024 +0200
@@ -157,25 +157,6 @@
         @testset test_boundary_grid(mg, TensorGridBoundary{2, Upper}(), J1)
     end
 
-    # TBD: Should curvilinear grid support refining and coarsening?
-    # This would require keeping the coordinate mapping around which seems burdensome, and might increase compilation time?
-    @testset "refine" begin
-        @test_broken refine(mg, 1) == mg
-        @test_broken refine(mg, 2) == MappedGrid(refine(lg,2), x̄, J)
-        @test_broken refine(mg, 3) == MappedGrid(refine(lg,3), x̄, J)
-    end
-
-    @testset "coarsen" begin
-        lg = equidistant_grid((11,11), (0,0), (1,1)) # TODO: Change dims of the grid to be different
-        x̄ = map(ξ̄ -> 2ξ̄, lg)
-        J = map(ξ̄ -> @SArray(fill(2., 2, 2)), lg)
-        mg = MappedGrid(lg, x̄, J)
-
-        @test_broken coarsen(mg, 1) == mg
-        @test_broken coarsen(mg, 2) == MappedGrid(coarsen(lg,2), x̄, J)
-
-        @test_broken false # @test_throws DomainError(3, "Size minus 1 must be divisible by the ratio.") coarsen(mg, 3)
-    end
 end
 
 @testset "mapped_grid" begin