Mercurial > repos > public > sbplib_julia
diff src/SbpOperators/boundaryops/boundary_operator.jl @ 1153:f1bb1b6d85dd refactor/sbpoperators/inflation
Review: Suggest changes to test and removal of conveninece constructor
| author | Vidar Stiernström <vidar.stiernstrom@it.uu.se> |
|---|---|
| date | Tue, 25 Oct 2022 10:33:27 +0200 |
| parents | 5ddf5ae48391 |
| children | ae006e844870 |
line wrap: on
line diff
--- a/src/SbpOperators/boundaryops/boundary_operator.jl Fri Oct 21 23:07:30 2022 +0200 +++ b/src/SbpOperators/boundaryops/boundary_operator.jl Tue Oct 25 10:33:27 2022 +0200 @@ -14,6 +14,10 @@ BoundaryOperator{R}(stencil::Stencil{T,N}, size::Int) where {T,R,N} = BoundaryOperator{T,R,N}(stencil, size) # TBD: Will the above convenience constructor ever be used? +# Review: +# It should probably be removed. It's kind of weird to have a convenice constructor +# for a general type if it isnt used by any of the current specializations. And in most cases the 1D constructor +# can be inflated. """ BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region)