Mercurial > repos > public > sbplib_julia

comparison src/SbpOperators/boundaryops/boundary_operator.jl @ 1153:f1bb1b6d85dd refactor/sbpoperators/inflation

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review: Suggest changes to test and removal of conveninece constructor
author Vidar Stiernström <vidar.stiernstrom@it.uu.se>
date Tue, 25 Oct 2022 10:33:27 +0200
parents 5ddf5ae48391
children ae006e844870
comparison
equal deleted inserted replaced
1151:56bc2c6a17fd 1153:f1bb1b6d85dd
12 size::Int 12 size::Int
13 end 13 end
14 14
15 BoundaryOperator{R}(stencil::Stencil{T,N}, size::Int) where {T,R,N} = BoundaryOperator{T,R,N}(stencil, size) 15 BoundaryOperator{R}(stencil::Stencil{T,N}, size::Int) where {T,R,N} = BoundaryOperator{T,R,N}(stencil, size)
16 # TBD: Will the above convenience constructor ever be used? 16 # TBD: Will the above convenience constructor ever be used?
17 # Review:
18 # It should probably be removed. It's kind of weird to have a convenice constructor
19 # for a general type if it isnt used by any of the current specializations. And in most cases the 1D constructor
20 # can be inflated.
17 21
18 """ 22 """
19 BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region) 23 BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region)
20 24
21 Constructs the BoundaryOperator with stencil `closure_stencil` for a one-dimensional `grid`, restricting to 25 Constructs the BoundaryOperator with stencil `closure_stencil` for a one-dimensional `grid`, restricting to