diff src/Grids/manifolds.jl @ 1644:e213bd857f3f feature/grids/manifolds

Add some todos and tbds
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 26 Jun 2024 11:06:32 +0200
parents 84c3b9d71218
children 2a8a2b52a112
line wrap: on
line diff
--- a/src/Grids/manifolds.jl	Mon Jun 24 21:36:27 2024 +0200
+++ b/src/Grids/manifolds.jl	Wed Jun 26 11:06:32 2024 +0200
@@ -19,6 +19,7 @@
 """
 abstract type ParameterSpace{D} end
 Base.ndims(::ParameterSpace{D}) where D = D
+# TBD:  Should implement domain_dim?
 
 struct HyperBox{T,D} <: ParameterSpace{D}
     a::SVector{D,T}
@@ -98,8 +99,11 @@
 which will both allow calling `jacobian(c,ξ)`.
 """
 jacobian(c::Chart, ξ) = jacobian(c.mapping, ξ)
+# TBD: Can we register a error hint for when jacobian is called with a function that doesn't have a registered jacobian?
 
 
+# TBD: Should Charts, parameterspaces have boundary names?
+
 """
     Atlas
 
@@ -199,4 +203,5 @@
     s(ξ̄...)
 end
 
+# TODO: Implement jacobian() for the different mapping helpers