Mercurial > repos > public > sbplib_julia

diff src/SbpOperators/boundaryops/boundary_operator.jl @ 1154:ae006e844870 refactor/sbpoperators/inflation

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove convenience constructor for BoundaryOperator according to review comments
author Jonatan Werpers <jonatan@werpers.com>
date Tue, 01 Nov 2022 22:10:51 +0100
parents f1bb1b6d85dd
children 716e721ce3eb
line wrap: on
line diff
--- a/src/SbpOperators/boundaryops/boundary_operator.jl	Tue Oct 25 10:33:27 2022 +0200
+++ b/src/SbpOperators/boundaryops/boundary_operator.jl	Tue Nov 01 22:10:51 2022 +0100
@@ -12,13 +12,6 @@
     size::Int
 end
 
-BoundaryOperator{R}(stencil::Stencil{T,N}, size::Int) where {T,R,N} = BoundaryOperator{T,R,N}(stencil, size)
-# TBD: Will the above convenience constructor ever be used?
-# Review: 
-# It should probably be removed. It's kind of weird to have a convenice constructor
-# for a general type if it isnt used by any of the current specializations. And in most cases the 1D constructor
-# can be inflated.
-
 """
     BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region)