Mercurial > repos > public > sbplib_julia

comparison src/SbpOperators/boundaryops/boundary_operator.jl @ 1154:ae006e844870 refactor/sbpoperators/inflation

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove convenience constructor for BoundaryOperator according to review comments
author Jonatan Werpers <jonatan@werpers.com>
date Tue, 01 Nov 2022 22:10:51 +0100
parents f1bb1b6d85dd
children 716e721ce3eb
comparison
equal deleted inserted replaced
1153:f1bb1b6d85dd 1154:ae006e844870
9 """ 9 """
10 struct BoundaryOperator{T,R<:Region,N} <: LazyTensor{T,0,1} 10 struct BoundaryOperator{T,R<:Region,N} <: LazyTensor{T,0,1}
11 stencil::Stencil{T,N} 11 stencil::Stencil{T,N}
12 size::Int 12 size::Int
13 end 13 end
14
15 BoundaryOperator{R}(stencil::Stencil{T,N}, size::Int) where {T,R,N} = BoundaryOperator{T,R,N}(stencil, size)
16 # TBD: Will the above convenience constructor ever be used?
17 # Review:
18 # It should probably be removed. It's kind of weird to have a convenice constructor
19 # for a general type if it isnt used by any of the current specializations. And in most cases the 1D constructor
20 # can be inflated.
21 14
22 """ 15 """
23 BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region) 16 BoundaryOperator(grid::EquidistantGrid{1}, closure_stencil, region)
24 17
25 Constructs the BoundaryOperator with stencil `closure_stencil` for a one-dimensional `grid`, restricting to 18 Constructs the BoundaryOperator with stencil `closure_stencil` for a one-dimensional `grid`, restricting to