Mercurial > repos > public > sbplib_julia

comparison src/SbpOperators/volumeops/volume_operator.jl @ 818:ae28f1d7ef5e refactor/sbp_operators_method_signatures

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Accept review comments
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 12 Jan 2022 15:48:29 +0100
parents a4d7ca5de3c6
children b41180efb6c2 469ed954b493 0a856fb96db4
comparison
equal deleted inserted replaced
810:a4d7ca5de3c6 818:ae28f1d7ef5e
7 corresponding `VolumeOperator` tensor mapping is returned. When `Dim>1`, the 7 corresponding `VolumeOperator` tensor mapping is returned. When `Dim>1`, the
8 returned operator is the appropriate outer product of a one-dimensional 8 returned operator is the appropriate outer product of a one-dimensional
9 operators and `IdentityMapping`s, e.g for `Dim=3` the volume operator in the 9 operators and `IdentityMapping`s, e.g for `Dim=3` the volume operator in the
10 y-direction is `I⊗op⊗I`. 10 y-direction is `I⊗op⊗I`.
11 """ 11 """
12 # Review: The type parameters Dim, T in the signature can be removed, 12 function volume_operator(grid::EquidistantGrid, inner_stencil, closure_stencils, parity, direction)
13 # by the following changes:
14 # one_d_grids = restrict.(Ref(grid), Tuple(1:Dim)) -->
15 # one_d_grids = restrict.(Ref(grid), Tuple(1:dimension(grid)))
16 # and
17 # Is = IdentityMapping{T}.(size.(one_d_grids)) -->
18 # Is = IdentityMapping{eltype(grid)}.(size.(one_d_grids))
19 function volume_operator(grid::EquidistantGrid{Dim,T}, inner_stencil, closure_stencils, parity, direction) where {Dim,T}
20 #TODO: Check that direction <= Dim? 13 #TODO: Check that direction <= Dim?
21 14
22 # Create 1D volume operator in along coordinate direction 15 # Create 1D volume operator in along coordinate direction
23 op = VolumeOperator(restrict(grid, direction), inner_stencil, closure_stencils, parity) 16 op = VolumeOperator(restrict(grid, direction), inner_stencil, closure_stencils, parity)
24 # Create 1D IdentityMappings for each coordinate direction 17 # Create 1D IdentityMappings for each coordinate direction
25 one_d_grids = restrict.(Ref(grid), Tuple(1:Dim)) 18 one_d_grids = restrict.(Ref(grid), Tuple(1:dimension(grid)))
26 Is = IdentityMapping{T}.(size.(one_d_grids)) 19 Is = IdentityMapping{eltype(grid)}.(size.(one_d_grids))
27 # Formulate the correct outer product sequence of the identity mappings and 20 # Formulate the correct outer product sequence of the identity mappings and
28 # the volume operator 21 # the volume operator
29 parts = Base.setindex(Is, op, direction) 22 parts = Base.setindex(Is, op, direction)
30 return foldl(⊗, parts) 23 return foldl(⊗, parts)
31 end 24 end