Mercurial > repos > public > sbplib_julia
comparison src/Grids/mapped_grid.jl @ 1776:265a740a49da feature/grids/curvilinear
Remove reivew comment regarding implementation of normal since it requires more computation and we know of no other benefits
| author | Jonatan Werpers <jonatan@werpers.com> |
|---|---|
| date | Sun, 15 Sep 2024 18:07:58 +0200 |
| parents | ecec2b0eea0f |
| children | 819ab806960f 43c0bfc13de3 |
comparison
equal
deleted
inserted
replaced
| 1775:ecec2b0eea0f | 1776:265a740a49da |
|---|---|
| 176 end | 176 end |
| 177 | 177 |
| 178 return ms | 178 return ms |
| 179 end | 179 end |
| 180 | 180 |
| 181 # Review: I would implement the normal through Nansons formula | |
| 182 # nⱼ = inv(Jᵧ)*J*Fⱼᵢ*νᵢ | |
| 183 # where | |
| 184 # Jᵧ boundary jacobian determiant | |
| 185 # J is the volume jacobian determinant | |
| 186 # Fⱼᵢ = dξᵢ/dxⱼ | |
| 187 # νᵢ normal on logical grid | |
| 188 # j: indices on physical grid | |
| 189 # i: indices on logical grid | |
| 190 # ξ: coordinate vector on logical grid | |
| 191 # x: coordinate vector on logical grid | |
| 192 # Perhaps the below is equivalent? | |
| 193 """ | 181 """ |
| 194 normal(g::MappedGrid, boundary) | 182 normal(g::MappedGrid, boundary) |
| 195 | 183 |
| 196 The outward pointing normal as a grid function on the corresponding boundary grid. | 184 The outward pointing normal as a grid function on the corresponding boundary grid. |
| 197 """ | 185 """ |