Mercurial > repos > public > sbplib_julia

annotate Notes.md @ 1277:79647b60a73b refactor/grids

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add and delete notes
author Jonatan Werpers <jonatan@werpers.com>
date Sun, 26 Feb 2023 17:09:51 +0100
parents a8fa8c1137cc
children 23f3b62388ba
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
318
0c8d4a734c4f Add some todos and add a Notes.md file
Jonatan Werpers <jonatan@werpers.com>
parents:
diff changeset
1 # Notes
0c8d4a734c4f Add some todos and add a Notes.md file
Jonatan Werpers <jonatan@werpers.com>
parents:
diff changeset
2
654
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
3 ## Reading operators
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
4
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
5 Jonatan's suggestion is to add methods to `Laplace`, `SecondDerivative` and
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
6 similar functions that take in a filename from which to read stencils. These
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
7 methods encode how to use the structure in a file to build the particular
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
8 operator. The filename should be a keyword argument and could have a default
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
9 value.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
10
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
11 * This allows easy creation of operators without the user having to handle stencils.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
12 * The user can easily switch between sets of operators by changing the file stecils are read from.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
13
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
14 Grids for optimized operators could be created by reading from a .toml file in
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
15 a similar fashion as for the operators. The grid can then be used in a
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
16 `Laplace` method which dispatches on the grid type and knows how to read the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
17 optimized operators. The method would also make sure the operators match the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
18 grid.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
19
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
20 Idea: Make the current upper case methods lower case. Add types with the upper
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
21 case names. These types are tensor mappings for the operator but also contain
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
22 the associated operators as fields. For example:
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
23
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
24 ```julia
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
25 L = Laplace(grid)
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
26 L.H
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
27 L.Hi
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
28 L.e
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
29 L.d
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
30 L.M
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
31
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
32 wave = L - L.Hi∘L.e'∘L.d
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
33 ```
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
34
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
35 These types could also contain things like borrowing and such.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
36
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
37 ## Storage of operators
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
38 We need to change the toml format so that it is easier to store several
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
39 operator with different kinds of differentiations. For example there could be
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
40 several operators of the same order but with different number of boundary
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
41 points or different choice of boundary stencils.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
42
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
43 Properties that differentiate operators should for this reason be stored in
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
44 variables and not be section or table names.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
45
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
46 Operators/sets of stencils should be stored in an [array of tables](https://toml.io/en/v1.0.0-rc.3#array-of-tables).
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
47
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
48 We should formalize the format and write simple and general access methods for
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
49 getting operators/sets of stencils from the file. They should support a simple
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
50 way to filter based on values of variables. There filters could possibly be
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
51 implemented through keyword arguments that are sent through all the layers of
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
52 operator creation.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
53
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
54 * Remove order as a table name and put it as a variable.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
55
853
fe8fe3f01162 Docs touch up
Jonatan Werpers <jonatan@werpers.com>
parents: 829
diff changeset
56 ### Parsing of stencil sets
829
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
57 At the moment the only parsing that can be done at the top level is conversion
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
58 from the toml file to a dict of strings. This forces the user to dig through
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
59 the dictionary and apply the correct parsing methods for the different parts,
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
60 e.g. `parse_stencil` or `parse_tuple`. While very flexible there is a tight
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
61 coupling between what is written in the file and what code is run to make data
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
62 in the file usable. While this coupling is hard to avoid it should be made
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
63 explicit. This could be done by putting a reference to a parsing function in
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
64 the operator-storage format or somehow specifying the type of each object.
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
65 This mechanism should be extensible without changing the package. Perhaps
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
66 there could be a way to register parsing functions or object types for the
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
67 toml.
1de10f5b2008 Add some notes on the format of operator storage
Jonatan Werpers <jonatan@werpers.com>
parents: 775
diff changeset
68
853
fe8fe3f01162 Docs touch up
Jonatan Werpers <jonatan@werpers.com>
parents: 829
diff changeset
69 If possible the goal should be for the parsing to get all the way to the
fe8fe3f01162 Docs touch up
Jonatan Werpers <jonatan@werpers.com>
parents: 829
diff changeset
70 stencils so that a user calls `read_stencil_set` and gets a
fe8fe3f01162 Docs touch up
Jonatan Werpers <jonatan@werpers.com>
parents: 829
diff changeset
71 dictionary-structure containing stencils, tuples, scalars and other types
fe8fe3f01162 Docs touch up
Jonatan Werpers <jonatan@werpers.com>
parents: 829
diff changeset
72 ready for input to the methods creating the operators.
654
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
73
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
74 ## Variable second derivative
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
75
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
76 2020-12-08 after discussion with Vidar:
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
77 We will have to handle the variable second derivative in a new variant of
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
78 VolumeOperator, "SecondDerivativeVariable?". Somehow it needs to know about
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
79 the coefficients. They should be provided as an AbstractVector. Where they are
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
80 provided is another question. It could be that you provide a reference to the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
81 array to the constructor of SecondDerivativeVariable. If that array is mutable
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
82 you are free to change it whenever and the changes should propagate
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
83 accordingly. Another option is that the counter part to "Laplace" for this
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
84 variable second derivate returns a function or acts like a functions that
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
85 takes an Abstract array and returns a SecondDerivativeVariable with the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
86 appropriate array. This would allow syntax like `D2(a)*v`. Can this be made
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
87 performant?
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
88
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
89 For the 1d case we can have a constructor
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
90 `SecondDerivativeVariable(D2::SecondDerivativeVariable, a)` that just creates
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
91 a copy with a different `a`.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
92
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
93 Apart from just the second derivative in 1D we need operators for higher
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
94 dimensions. What happens if a=a(x,y)? Maybe this can be solved orthogonally to
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
95 the `D2(a)*v` issue, meaning that if a constant nD version of
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
96 SecondDerivativeVariable is available then maybe it can be wrapped to support
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
97 function like syntax. We might have to implement `SecondDerivativeVariable`
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
98 for N dimensions which takes a N dimensional a. If this could be easily
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
99 closured to allow D(a) syntax we would have come a long way.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
100
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
101 For `Laplace` which might use a variable D2 if it is on a curvilinear grid we
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
102 might want to choose how to calculate the metric coefficients. They could be
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
103 known on closed form, they could be calculated from the grid coordinates or
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
104 they could be provided as a vector. Which way you want to do it might change
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
105 depending on for example if you are memory bound or compute bound. This choice
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
106 cannot be done on the grid since the grid shouldn't care about the computer
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
107 architecture. The most sensible option seems to be to have an argument to the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
108 `Laplace` function which controls how the coefficients are gotten from the
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
109 grid. The argument could for example be a function which is to be applied to
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
110 the grid.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
111
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
112 What happens if the grid or the varible coefficient is dependent on time?
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
113 Maybe it becomes important to support `D(a)` or even `D(t,a)` syntax in a more
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
114 general way.
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
115
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
116 ```
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
117 g = TimeDependentGrid()
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
118 L = Laplace(g)
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
119 function Laplace(g::TimeDependentGrid)
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
120 g_logical = logical(g) # g_logical is time independent
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
121 ... Build a L(a) assuming we can do that ...
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
122 a(t) = metric_coeffs(g,t)
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
123 return t->L(a(t))
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
124 end
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
125 ```
d26231227b89 Add a bunch of notes on reading and storing operators and how to implement variable second derivatives
Jonatan Werpers <jonatan@werpers.com>
parents: 606
diff changeset
126
318
0c8d4a734c4f Add some todos and add a Notes.md file
Jonatan Werpers <jonatan@werpers.com>
parents:
diff changeset
127 ## Known size of range and domain?
320
d705b397aa33 Clean up Notes.md and TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents: 319
diff changeset
128 Is there any reason to use a trait to differentiate between fixed size and unknown size?
d705b397aa33 Clean up Notes.md and TODO.md
Jonatan Werpers <jonatan@werpers.com>
parents: 319
diff changeset
129
379
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
130 When do we need to know the size of the range and domain?
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
131 * When indexing to provide boundschecking?
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
132 * When doing specialised computations for different parts of the range/domain?
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
133 * More?
319
05ac7d7f9176 Move research and thinking from TODO.md to Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 318
diff changeset
134
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
135 Maybe if we should have dynamic sizing it could be only for the range. `domain_size` would not be implemented. And the `range_size` would be a function of a vector that the LazyTensor is applied to.
332
535f1bff4bcc Add some notes and some todos
Jonatan Werpers <jonatan@werpers.com>
parents: 320
diff changeset
136
319
05ac7d7f9176 Move research and thinking from TODO.md to Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 318
diff changeset
137 ## Reasearch and thinking
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
138 - [ ] Use a trait to indicate that a LazyTensor har the same range and domain?
319
05ac7d7f9176 Move research and thinking from TODO.md to Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 318
diff changeset
139 - [ ] Check how the native julia doc generator works
05ac7d7f9176 Move research and thinking from TODO.md to Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 318
diff changeset
140 - [ ] Check if Vidars design docs fit in there
05ac7d7f9176 Move research and thinking from TODO.md to Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 318
diff changeset
141 - [ ] Create a macro @lazy which replaces a binary op (+,-) by its lazy equivalent? Would be a neat way to indicate which evaluations are lazy without cluttering/confusing with special characters.
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
142 - [ ] Dispatch on Lower() instead of the type Lower so `::Lower` instead of `::Type{Lower}` ???
332
535f1bff4bcc Add some notes and some todos
Jonatan Werpers <jonatan@werpers.com>
parents: 320
diff changeset
143 Seems better unless there is some specific reason to use the type instead of the value.
379
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
144 - [ ] How do we handle mixes of periodic and non-periodic grids? Seems it should be supported on the grid level and on the 1d operator level. Between there it should be transparent.
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
145 - [ ] Can we have a trait to tell if a LazyTensor is transposable?
379
de4746d6d126 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 332
diff changeset
146 - [ ] Is it ok to have "Constructors" for abstract types which create subtypes? For example a Grids() functions that gives different kind of grids based on input?
663
f1803ab08740 Add Note on how we should treat the borrowing parameters of operators.
Vidar Stiernström <vidar.stiernstrom@it.uu.se>
parents: 654
diff changeset
147 - [ ] Figure out how to treat the borrowing parameters of operators. Include in into the struct? Expose via function dispatched on the operator type and grid?
410
26e186b565b3 Add some notes about vector valued grid functions
Jonatan Werpers <jonatan@werpers.com>
parents: 379
diff changeset
148
1050
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
149 ## Identifiers for regions
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
150 The identifiers (`Upper`, `Lower`, `Interior`) used for region indecies should probabily be included in the grid module. This allows new grid types to come with their own regions.
1222
5f677cd6f0b6 Start refactoring
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
151 We implement this by refactoring RegionIndices to be agnostic to the region types and then moving the actual types to Grids.
1050
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
152
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
153 ## Regions and tensormappings
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
154 - [ ] Use a trait to indicate if a LazyTensor uses indices with regions.
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
155 The default should be that they do NOT.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
156 - [ ] What to name this trait? Can we call it IndexStyle but not export it to avoid conflicts with Base.IndexStyle?
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
157 - [ ] Figure out repeated application of regioned LazyTensors. Maybe an instance of a tensor mapping needs to know the exact size of the range and domain for this to work?
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
158
1050
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
159 ### Ideas for information sharing functions
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
160 ```julia
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
161 using StaticArrays
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
162
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
163 function regions(op::SecondDerivativeVariable)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
164 t = ntuple(i->(Interior(),),range_dim(op))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
165 return Base.setindex(t, (Lower(), Interior(), Upper()), derivative_direction(op))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
166 end
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
167
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
168 function regionsizes(op::SecondDerivativeVariable)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
169 sz = tuple.(range_size(op))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
170
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
171 cl = closuresize(op)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
172 return Base.setindex(sz, (cl, n-2cl, cl), derivative_direction(op))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
173 end
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
174
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
175
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
176 g = EquidistantGrid((11,9), (0.,0.), (10.,8.)) # h = 1
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
177 c = evalOn(g, (x,y)->x+y)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
178
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
179 D₂ᶜ = SecondDerivativeVariable(g, c, interior_stencil, closure_stencils,1)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
180 @test regions(D₂ᶜ) == (
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
181 (Lower(), Interior(), Upper()),
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
182 (Interior(),),
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
183 )
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
184 @test regionsizes(D₂ᶜ) == ((1,9,1),(9,))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
185
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
186
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
187 D₂ᶜ = SecondDerivativeVariable(g, c, interior_stencil, closure_stencils,2)
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
188 @test regions(D₂ᶜ) == (
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
189 (Interior(),),
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
190 (Lower(), Interior(), Upper()),
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
191 )
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
192 @test regionsizes(D₂ᶜ) == ((11,),(1,7,1))
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
193 ```
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
194
396278072f18 Add some notes and clean up TODO.md a little bit
Jonatan Werpers <jonatan@werpers.com>
parents: 1041
diff changeset
195
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
196 ## Boundschecking and dimension checking
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
197 Does it make sense to have boundschecking only in getindex methods?
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
198 This would mean no bounds checking in applys, however any indexing that they do would be boundschecked. The only loss would be readability of errors. But users aren't really supposed to call apply directly anyway.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
199
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
200 Preferably dimensions and sizes should be checked when lazy objects are created, for example TensorApplication, TensorComposition and so on. If dimension checks decreases performance we can make them skippable later.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
201
410
26e186b565b3 Add some notes about vector valued grid functions
Jonatan Werpers <jonatan@werpers.com>
parents: 379
diff changeset
202 ## Vector valued grid functions
423
10a67ac48d6e Add some notes
Jonatan Werpers <jonatan@werpers.com>
parents: 410
diff changeset
203
10a67ac48d6e Add some notes
Jonatan Werpers <jonatan@werpers.com>
parents: 410
diff changeset
204 ### Test-applikationer
10a67ac48d6e Add some notes
Jonatan Werpers <jonatan@werpers.com>
parents: 410
diff changeset
205 div och grad operationer
10a67ac48d6e Add some notes
Jonatan Werpers <jonatan@werpers.com>
parents: 410
diff changeset
206
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
207 Enligt Wikipedia verkar det som att `∇⋅` agerar på första dimensionen av ett tensor fält och `div()` på sista.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
208 Om man generaliserar kanske `∇` i så fall bara lägger till en dimension i början.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
209
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
210 Kan vi implementera `⋅`(\cdot) så att de fungerar som man vill för både tensor-fält och tensor-operatorer?
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
211
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
212 Är `∇` ett tensor-fält av tensor-operatorer? Vad är ett tensor-fält i vår kod? Är det en special-fall av en tensor-mapping?
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
213
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
214 ### Grid-funktionen
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
215 Grid-funktionon har typen `AbstractArray{T,2} where T`.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
216 `T` kan vara lite vad som helst, tillexemel en SVector eller Array, eller tuple. TensorOperatorerna bryr sig inte om exakt vad det är, mer än att typen måste stödja de operationer som operatorn använder.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
217
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
218 En nackdel kan vara hur man ska få ut gridfunktionen för tex andra komponenten.
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
219
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
220 Syntax:
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
221 ```
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
222 f(x̄) = x̄
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
223 gf = evalOn(g, f)
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
224 gf[2,3] # x̄ för en viss gridpunkt
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
225 gf[2,3][2] # x̄[2] för en viss gridpunkt
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
226 ```
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
227
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
228 Note: Behöver bestämma om eval on skickar in `x̄` eller `x̄...` till `f`. Eller om man kan stödja båda.
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
229
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
230 ### Tensor operatorer
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
231 Vi kan ha tensor-operatorer som agerar på ett skalärt fält och ger ett vektorfält eller tensorfält.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
232 Vi kan också ha tensor-operatorer som agerar på ett vektorfält eller tensorfält och ger ett skalärt fält.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
233
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
234 TBD: Just nu gör `apply_transpose` antagandet att domän-typen är samma som range-typen. Det behöver vi på något sätt bryta. Ett alternativ är låta en LazyTensor ha `T_domain` och `T_range` istället för bara `T`. Känns dock lite grötigt. Ett annat alternativ skulle vara någon typ av trait för transpose? Den skulle kunna innehålla typen som transponatet agerar på? Vet inte om det fungerar dock.
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
235
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
236 TBD: Vad är målet med `T`-parametern för en LazyTensor? Om vi vill kunna applicera en difference operator på vad som helst kan man inte anta att en `LazyTensor{T}` bara agerar på instanser av `T`.
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
237
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
238 Man kan implementera `∇` som en tensormapping som agerar på T och returnerar `StaticVector{N,T} where N`.
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
239 (Man skulle eventuellt också kunna låta den agera på `StaticMatrix{N,T,D} where N` och returnera `StaticMatrix{M,T,D+1}`. Frågan är om man vinner något på det...)
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
240
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
241 Skulle kunna ha en funktion `range_type(::LazyTensor, ::Type{domain_type})`
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
242
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
243 Kanske kan man implementera `⋅(tm::LazyTensor{R,D}, v::AbstractArray{T,D})` där T är en AbstractArray, tm på något sätt har komponenter, lika många som T har element.
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
244
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
245 ### Komponenter som gridfunktioner
606
8f9b3eac128a Add a bunch of stuff to TODO.md and Notes.md
Jonatan Werpers <jonatan@werpers.com>
parents: 427
diff changeset
246 En viktig operation för vektor fält är att kunna få ut komponenter som grid-funktioner. Detta behöver antagligen kunna ske lazy.
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
247 Det finns ett par olika lösningar:
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
248 * Implementera en egen typ av view som tar hand om detta. Eller Accessors.jl?
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
249 * Använda en LazyTensor
427
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
250 * Någon typ av lazy-broadcast
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
251 * En lazy array som applicerar en funktion för varje element.
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
252
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
253 Skulle vara en fördel om det är hyffsat generiskt så att en eventuell användare kan utöka det enkelt om de har någon egen exotisk typ. Eller ska man vila helt på
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
254
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
255 Syntax:
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
256 ```
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
257 gf = eval(...)
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
258 component(gf,2) # Andra komponenten av en vektor
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
259 component(gf,2,3) # (2,3) elementet av en matris
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
260 component(gf,:,2) # Andra kolumnen av en matris
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
261 @ourview gf[:,:][2]
1c41f4fd3e61 Add some notes and todos
Jonatan Werpers <jonatan@werpers.com>
parents: 423
diff changeset
262 ```
683
841ca12f3359 Add notes about embedded grids
Jonatan Werpers <jonatan@werpers.com>
parents: 654
diff changeset
263
718
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
264 ## Performance measuring
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
265 We should be measuring performance early. How does our effective cpu and memory bandwidth utilization compare to peak performance?
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
266
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
267 We should make these test simple to run for any solver.
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
268
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
269 See [this talk](https://www.youtube.com/watch?v=vPsfZUqI4_0) for some simple ideas for defining effecive memory usage and some comparison with peak performance.
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
270
05d8ea88c690 Add note about performance testin
Jonatan Werpers <jonatan@werpers.com>
parents: 683
diff changeset
271
761
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
272 ## Adjoint as a trait on the sbp_operator level?
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
273
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
274 It would be nice to have a way of refering to adjoints with resepct to the sbp-inner-product.
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
275 If it was possible you could reduce the number of times you have to deal with the inner product matrix.
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
276
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
277 Since the LazyOperators package is sort of implementing matrix-free matrices there is no concept of inner products there at the moment. It seems to complicate large parts of the package if this was included there.
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
278
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
279 A different approach would be to include it as a trait for operators so that you can specify what the adjoint for that operator is.
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
280
d7d030f8f708 Add note about adjoint as trait
Jonatan Werpers <jonatan@werpers.com>
parents: 718
diff changeset
281
775
1d166e7a9deb Add a note about the name of VolumeOperator
Jonatan Werpers <jonatan@werpers.com>
parents: 761
diff changeset
282 ## Name of the `VolumeOperator` type for constant stencils
995
1ba8a398af9c Rename types
Jonatan Werpers <jonatan@werpers.com>
parents: 866
diff changeset
283 It seems that the name is too general. The name of the method `volume_operator` makes sense. It should return different types of `LazyTensor` specialized for the grid. A suggetion for a better name is `ConstantStencilVolumeOperator`
1224
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
284
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
285
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
286 ## Implementation of LazyOuterProduct
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
287 Could the implementation of LazyOuterProduct be simplified by making it a
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
288 struct containing two or more LazyTensors? (using split_tuple in a similar way
e2f6dafb5d83 Add note about LazyOuterProduct
Jonatan Werpers <jonatan@werpers.com>
parents: 1050
diff changeset
289 as TensorGrid)