Mercurial > repos > public > sbplib_julia

changeset 737:ca4f17efb279 feature/static_dict

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Change to using DomainError
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 17 Mar 2021 21:47:16 +0100
parents b5d9fbcdcef1
children 0ed147a4068a
files src/StaticDicts/StaticDicts.jl test/testStaticDicts.jl
diffstat 2 files changed, 3 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/StaticDicts/StaticDicts.jl	Wed Mar 17 21:45:59 2021 +0100
+++ b/src/StaticDicts/StaticDicts.jl	Wed Mar 17 21:47:16 2021 +0100
@@ -25,7 +25,7 @@
 
     function StaticDict{K,V,N}(pairs::Tuple) where {K,V,N}
         if !allunique(first.(pairs))
-            throw(ArgumentError("keys must be unique (for now)"))
+            throw(DomainError(pairs, "keys must be unique"))
         end
         return new{K,V,N}(pairs)
     end
--- a/test/testStaticDicts.jl	Wed Mar 17 21:45:59 2021 +0100
+++ b/test/testStaticDicts.jl	Wed Mar 17 21:47:16 2021 +0100
@@ -18,8 +18,7 @@
         @test StaticDict(1. =>3, 2=>4) isa StaticDict{Real,Int}
         @test StaticDict(1. =>3, 2=>4.) isa StaticDict{Real,Real}
 
-        @test_throws ArgumentError StaticDict(1=>3, 1=>3)
-        #TBD: is ArgumentError correct?
+        @test_throws DomainError StaticDict(1=>3, 1=>3)
     end
 
     @testset "equality" begin
@@ -47,7 +46,7 @@
             StaticDict(3=>5,4=>6)) == StaticDict(
                 1=>3, 2=>4, 3=>5, 4=>6
             )
-        @test_throws ArgumentError merge(StaticDict(1=>3),StaticDict(1=>3))
+        @test_throws DomainError merge(StaticDict(1=>3),StaticDict(1=>3))
     end
 end