Mercurial > repos > public > sbplib_julia

changeset 1942:b8395f69ad80 feature/grids/manifolds

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add boundaries(::Chart) and broken tests
author Jonatan Werpers <jonatan@werpers.com>
date Fri, 07 Feb 2025 14:05:37 +0100
parents 1e3089197397
children 48c49c04f3b2
files src/Grids/manifolds.jl test/Grids/manifolds_test.jl
diffstat 2 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/manifolds.jl	Fri Feb 07 13:59:13 2025 +0100
+++ b/src/Grids/manifolds.jl	Fri Feb 07 14:05:37 2025 +0100
@@ -33,8 +33,8 @@
 jacobian(c::Chart, ξ) = jacobian(c.mapping, ξ)
 # TBD: Can we register a error hint for when jacobian is called with a function that doesn't have a registered jacobian?
 
+boundaries(c::Chart) = boundaries(parameterspace(c))
 
-# TBD: Should Charts, parameterspaces, Atlases, have boundary names?
 
 """
     Atlas
--- a/test/Grids/manifolds_test.jl	Fri Feb 07 13:59:13 2025 +0100
+++ b/test/Grids/manifolds_test.jl	Fri Feb 07 14:05:37 2025 +0100
@@ -23,6 +23,8 @@
     @test ndims(c) == 2
 
     @test jacobian(c, [3,2]) == [2,2]
+
+    @test_broken Set(boundaries(X,unitsquare())) == Set([east,west,south,north])
 end
 
 @testset "CartesianAtlas" begin