changeset 2090:67d8fbbb9e58 refactor/sbp_operators/direction_check

Update error messages
author Jonatan Werpers <jonatan@werpers.com>
date Mon, 02 Mar 2026 14:21:58 +0100
parents 1bc63fa55145
children e21c295fb2da
files src/SbpOperators/volumeops/derivatives/first_derivative.jl src/SbpOperators/volumeops/derivatives/second_derivative.jl src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl test/SbpOperators/volumeops/derivatives/first_derivative_test.jl test/SbpOperators/volumeops/derivatives/second_derivative_test.jl test/SbpOperators/volumeops/derivatives/second_derivative_variable_test.jl
diffstat 6 files changed, 6 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/src/SbpOperators/volumeops/derivatives/first_derivative.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/src/SbpOperators/volumeops/derivatives/first_derivative.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -15,7 +15,7 @@
 """
 function first_derivative(g::TensorGrid, stencil_set, dim)
     if dim ∉ 1:ndims(g)
-        throw(DomainError(dim, "Direction must be inside [0, $(ndims(g))]."))
+        throw(DomainError(dim, "Derivative direction must be in 1:$(ndims(g))."))
     end
     D₁ = first_derivative(g.grids[dim], stencil_set)
     return LazyTensors.inflate(D₁, size(g), dim)
--- a/src/SbpOperators/volumeops/derivatives/second_derivative.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/src/SbpOperators/volumeops/derivatives/second_derivative.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -11,7 +11,7 @@
 """
 function second_derivative(g::TensorGrid, stencil_set, dim)
     if dim ∉ 1:ndims(g)
-        throw(DomainError(dim, "Direction must be inside [0, $(ndims(g))]."))
+        throw(DomainError(dim, "Derivative direction must be in 1:$(ndims(g))."))
     end
     D₂ = second_derivative(g.grids[dim], stencil_set)
     return LazyTensors.inflate(D₂, size(g), dim)
--- a/src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -11,7 +11,7 @@
 
 function second_derivative_variable(g::TensorGrid, coeff, stencil_set, dim::Int)
     if dim ∉ 1:ndims(g)
-        throw(DomainError(dim, "Direction must be inside [0, $(ndims(g))]."))
+        throw(DomainError(dim, "Derivative direction must be in 1:$(ndims(g))."))
     end
     inner_stencil    = parse_nested_stencil(eltype(coeff), stencil_set["D2variable"]["inner_stencil"])
     closure_stencils = parse_nested_stencil.(eltype(coeff), stencil_set["D2variable"]["closure_stencils"])
--- a/test/SbpOperators/volumeops/derivatives/first_derivative_test.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/test/SbpOperators/volumeops/derivatives/first_derivative_test.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -18,7 +18,7 @@
         @test first_derivative(g₂, stencil_set, 2) isa LazyTensor{Float64,2,2}
         
         @test first_derivative(g₁, stencil_set) == first_derivative(g₁, stencil_set, 1)
-        @test_throws DomainError(3, "Direction must be inside [0, 1].") first_derivative(g₁, stencil_set, 3)
+        @test_throws DomainError(3, "Derivative direction must be in 1:1.") first_derivative(g₁, stencil_set, 3)
 
         interior_stencil = CenteredStencil(-1,0,1)
         closure_stencils = [Stencil(-1,1, center=1)]
--- a/test/SbpOperators/volumeops/derivatives/second_derivative_test.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/test/SbpOperators/volumeops/derivatives/second_derivative_test.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -25,7 +25,7 @@
             @test Dₓₓ == second_derivative(g_1D, inner_stencil, closure_stencils)
             @test Dₓₓ isa LazyTensor{Float64,1,1}
 
-            @test_throws DomainError(3, "Direction must be inside [0, 1].") second_derivative(g_1D, stencil_set, 3)
+            @test_throws DomainError(3, "Derivative direction must be in 1:1.") second_derivative(g_1D, stencil_set, 3)
         end
         @testset "2D" begin
             Dₓₓ = second_derivative(g_2D,stencil_set,1)
--- a/test/SbpOperators/volumeops/derivatives/second_derivative_variable_test.jl	Mon Mar 02 14:11:32 2026 +0100
+++ b/test/SbpOperators/volumeops/derivatives/second_derivative_variable_test.jl	Mon Mar 02 14:21:58 2026 +0100
@@ -45,7 +45,7 @@
         @testset "checking direction" begin
             c = rand(size(g)...)
             second_derivative_variable(g, c, stencil_set, 1) == second_derivative_variable(g, c, stencil_set)
-            @test_throws DomainError(2, "Direction must be inside [0, 1].") second_derivative_variable(g, c, stencil_set, 2)
+            @test_throws DomainError(2, "Derivative direction must be in 1:1.") second_derivative_variable(g, c, stencil_set, 2)
         end
     end