changeset 1768:672897f64d58 feature/grids/curvilinear

More reivew comments
author Vidar Stiernström <vidar.stiernstrom@gmail.com>
date Fri, 13 Sep 2024 13:35:20 -0700
parents c98d9c528a22
children 08e52f442872
files src/Grids/mapped_grid.jl
diffstat 1 files changed, 15 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl	Fri Sep 13 10:27:17 2024 -0700
+++ b/src/Grids/mapped_grid.jl	Fri Sep 13 13:35:20 2024 -0700
@@ -74,6 +74,8 @@
 boundary_identifiers(g::MappedGrid) = boundary_identifiers(g.logicalgrid)
 boundary_indices(g::MappedGrid, id::TensorGridBoundary) = boundary_indices(g.logicalgrid, id)
 
+# Review: Error when calling plot(boundary_grid(g, id))
+# Currently need to collect first, i.e., plot(collect(boundary_grid(g, id)))
 function boundary_grid(g::MappedGrid, id::TensorGridBoundary)
     b_indices = boundary_indices(g.logicalgrid, id)
 
@@ -122,6 +124,7 @@
     )
 end
 
+# Review: Error when calling jacobian_determinant(boundary_grid(g,id))
 """
     jacobian_determinant(g::MappedGrid)
 
@@ -200,6 +203,18 @@
     return ms
 end
 
+# Review: I would implement the normal through Nansons formula
+# nⱼ = inv(Jᵧ)*J*Fⱼᵢ*νᵢ
+# where 
+# Jᵧ  boundary jacobian determiant
+# J is the volume jacobian determinant
+# Fⱼᵢ = dξᵢ/dxⱼ
+# νᵢ normal on logical grid
+# j: indices on physical grid
+# i: indices on logical grid
+# ξ: coordinate vector on logical grid
+# x: coordinate vector on logical grid
+# Perhaps the below is equivalent?
 """
     normal(g::MappedGrid, boundary)