Mercurial > repos > public > sbplib_julia

changeset 1413:410bc321242c bugfix/grids/complete_interface_impl

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add todo for colon-indexing and remove tests
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 23 Aug 2023 09:32:01 +0200
parents e56277744ebb
children 1aa8adbf13d5
files TODO.md test/Grids/equidistant_grid_test.jl test/Grids/tensor_grid_test.jl
diffstat 3 files changed, 1 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/TODO.md	Tue Aug 22 22:39:03 2023 +0200
+++ b/TODO.md	Wed Aug 23 09:32:01 2023 +0200
@@ -35,6 +35,7 @@
  - [ ] Multiblock grids
  - [ ] Periodic grids
  - [ ] Grids with modified boundary closures
+ - [ ] Support indexing with `:`.
 
 
 ### Benchmarks
--- a/test/Grids/equidistant_grid_test.jl	Tue Aug 22 22:39:03 2023 +0200
+++ b/test/Grids/equidistant_grid_test.jl	Wed Aug 23 09:32:01 2023 +0200
@@ -23,8 +23,6 @@
         @test firstindex(g) == 1
         @test lastindex(g) == 101
 
-        @test g[:] == g[1:101]
-        
         @test axes(g,1) == 1:101
         @test axes(g) == (1:101,)
     end
--- a/test/Grids/tensor_grid_test.jl	Tue Aug 22 22:39:03 2023 +0200
+++ b/test/Grids/tensor_grid_test.jl	Wed Aug 23 09:32:01 2023 +0200
@@ -43,9 +43,6 @@
             @test axes(g, 1) == 1:11
             @test axes(g, 2) == 1:6
             @test axes(g) == (1:11,1:6)
-
-            # REVIEW: Would be nice if this worked.
-            @test_broken g[:, end] == g[1:11,6]
         end
 
         @testset "cartesian indexing" begin