Mercurial > repos > public > sbplib_julia

diff test/SbpOperators/boundaryops/boundary_operator_test.jl @ 1153:f1bb1b6d85dd refactor/sbpoperators/inflation

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review: Suggest changes to test and removal of conveninece constructor
author Vidar Stiernström <vidar.stiernstrom@it.uu.se>
date Tue, 25 Oct 2022 10:33:27 +0200
parents 6b24dc2d7b11
children ae006e844870
line wrap: on
line diff
--- a/test/SbpOperators/boundaryops/boundary_operator_test.jl	Fri Oct 21 23:07:30 2022 +0200
+++ b/test/SbpOperators/boundaryops/boundary_operator_test.jl	Tue Oct 25 10:33:27 2022 +0200
@@ -14,10 +14,11 @@
     g_2D = EquidistantGrid((11,15), (0.0, 0.0), (1.0,1.0))
 
     @testset "Constructors" begin
+        # Review: Remove the first line below in case we remove convenience constructor in BoundaryOperator
         op_l = BoundaryOperator{Lower}(closure_stencil,size(g_1D)[1])
         @test op_l == BoundaryOperator(g_1D,closure_stencil,Lower())
         @test op_l isa LazyTensor{T,0,1} where T
-
+         # Review: Remove the first line below in case we remove convenience constructor in BoundaryOperator
         op_r = BoundaryOperator{Upper}(closure_stencil,size(g_1D)[1])
         @test op_r == BoundaryOperator(g_1D,closure_stencil,Upper())
         @test op_r isa LazyTensor{T,0,1} where T