diff src/Grids/mapped_grid.jl @ 1775:ecec2b0eea0f feature/grids/curvilinear

Delete jacobian_determinant. User should use map or broadcasting with det instead.
author Jonatan Werpers <jonatan@werpers.com>
date Sun, 15 Sep 2024 18:05:57 +0200
parents 035af82f559a
children 265a740a49da
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl	Sun Sep 15 18:03:37 2024 +0200
+++ b/src/Grids/mapped_grid.jl	Sun Sep 15 18:05:57 2024 +0200
@@ -122,29 +122,6 @@
     )
 end
 
-# Review: Error when calling jacobian_determinant(boundary_grid(g,id))
-"""
-    jacobian_determinant(g::MappedGrid)
-
-The jacobian determinant of `g` as a grid function.
-"""
-function jacobian_determinant(g::MappedGrid)
-    return map(jacobian(g)) do ∂x∂ξ
-        det(∂x∂ξ)
-    end
-end
-# TBD: Should this be changed to calculate sqrt(g) instead?
-#       This would make it well defined also for n-dim grids embedded in higher dimensions.
-# TBD: Is there a better name? metric_determinant?
-# TBD: Is the best option to delete it?
-# Review: I don't think we should delete it. Users building their own 
-#         curvilinear operators will need the functionality. Also the
-#         determinant of the jacobian (and not its square root) is required
-#         for quadratures on mapped grids right? For that reason I think we should
-#         keep the function as is. We could provide a function for the square root
-#         as well if we think it would be helpfull. Regarding naming, perhaps
-#         metric_determinant is better?
-
 """
     metric_tensor(g::MappedGrid)