diff src/Grids/mapped_grid.jl @ 1868:81559cb7b11c feature/grids/manifolds

Merge default
author Jonatan Werpers <jonatan@werpers.com>
date Thu, 23 Jan 2025 23:22:11 +0100
parents f2b32da29b73 a57cd6fa4ecb
children edee7d677efb
line wrap: on
line diff
--- a/src/Grids/mapped_grid.jl	Tue Nov 12 18:15:27 2024 +0100
+++ b/src/Grids/mapped_grid.jl	Thu Jan 23 23:22:11 2025 +0100
@@ -92,27 +92,27 @@
     )
 end
 
-
+# TODO: Make sure all methods of `mapped_grid` are implemented correctly and tested.
 """
     mapped_grid(x, J, size::Vararg{Int})
 
 A `MappedGrid` with a default logical grid on the D-dimensional unit hyper 
-box [0,1]ᴰ. `x` and `J`are functions to be evaluated on the logical grid
+box [0,1]ᴰ. `x` and `J` are functions to be evaluated on the logical grid
 and `size` determines the size of the logical grid.
 """
 function mapped_grid(x, J, size::Vararg{Int})
     D = length(size)
-    lg = equidistant_grid(ntuple(i->0., D), ntuple(i->1., D), size...)
-    return mapped_grid(lg, x, J)
+        lg = equidistant_grid(ntuple(i->0., D), ntuple(i->1., D), size...) # TODO: Clean this up with ParamaterSpace once feature/grids/manifolds is merged
+    return mapped_grid(x, J, lg)
 end
 
 """
-    mapped_grid(lg::Grid, x, J)
+    mapped_grid(x, J, lg::Grid)
 
 A `MappedGrid` with logical grid `lg`. Physical coordinates and Jacobian are
 determined by the functions `x` and `J`.
 """
-function mapped_grid(lg::Grid, x, J)
+function mapped_grid(x, J, lg::Grid)
     return MappedGrid(
         lg,
         map(x,lg),
@@ -128,7 +128,7 @@
 """
 function mapped_grid(x, J, ps::ParameterSpace, size::Vararg{Int})
     lg = equidistant_grid(ps, size...)
-    return mapped_grid(lg, x, J)
+    return mapped_grid(x, J, lg)
 end
 
 """