Mercurial > repos > public > sbplib_julia
diff src/BoundaryConditions/boundary_condition.jl @ 1599:37b05221beda feature/boundary_conditions
Review
author | Jonatan Werpers <jonatan@werpers.com> |
---|---|
date | Wed, 29 May 2024 22:35:08 +0200 |
parents | ee242c3fe4af |
children | 3e7438e2a033 |
line wrap: on
line diff
--- a/src/BoundaryConditions/boundary_condition.jl Sun May 26 18:19:02 2024 -0700 +++ b/src/BoundaryConditions/boundary_condition.jl Wed May 29 22:35:08 2024 +0200 @@ -4,7 +4,7 @@ A type for implementing data needed in order to impose a boundary condition. Subtypes refer to perticular types of boundary conditions, e.g. Neumann conditions. """ -abstract type BoundaryCondition{T1,T2} end +abstract type BoundaryCondition{T1,T2} end # REVIEW: No type parameters needed here. """ id(::BoundaryCondition) @@ -33,14 +33,14 @@ struct DirichletCondition{T1,T2} <: BoundaryCondition{T1,T2} data::T1 - id::T2 + id::T2 # REVIEW: This field not needed since BoundaryId are usually type parameters? end id(bc::DirichletCondition) = bc.id data(bc::DirichletCondition) = bc.data struct NeumannCondition{T1,T2} <: BoundaryCondition{T1,T2} data::T1 - id::T2 + id::T2 # REVIEW: This field not needed since BoundaryId are usually type parameters? end id(bc::NeumannCondition) = bc.id data(bc::NeumannCondition) = bc.data