Mercurial > repos > public > sbplib_julia

diff src/BoundaryConditions/BoundaryConditions.jl @ 1599:37b05221beda feature/boundary_conditions

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 29 May 2024 22:35:08 +0200
parents da1b85c80a3f
children 3e7438e2a033
line wrap: on
line diff
--- a/src/BoundaryConditions/BoundaryConditions.jl	Sun May 26 18:19:02 2024 -0700
+++ b/src/BoundaryConditions/BoundaryConditions.jl	Wed May 29 22:35:08 2024 +0200
@@ -1,10 +1,11 @@
 module BoundaryConditions
 
+# REVIEW: Does this need to be in a separate module? I feel like it fits quite well into SbpOperators.
 
 export BoundaryCondition
 export discretize_data
-export data
-export id
+export data # REVIEW: Name too generic to export.
+export id # REVIEW: Also to generic. Change to `boundary`?
 
 export NeumannCondition
 export DirichletCondition