diff src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl @ 1382:1aee4e6206c2 feature/variable_derivatives

Merge
author Jonatan Werpers <jonatan@werpers.com>
date Thu, 08 Jun 2023 15:51:52 +0200
parents e9dfc1998d31
children 3684db043add
line wrap: on
line diff
--- a/src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl	Tue May 30 17:27:45 2023 +0200
+++ b/src/SbpOperators/volumeops/derivatives/second_derivative_variable.jl	Thu Jun 08 15:51:52 2023 +0200
@@ -40,7 +40,6 @@
 end
 
 
-# REVIEW: Fixa docs
 """
     SecondDerivativeVariable{Dir,T,D,...} <: LazyTensor{T,D,D}
 
@@ -130,13 +129,13 @@
         I = Base.setindex(I, Index(i, Upper), dir)
         return LazyTensors.apply(op, v, I...)
     else
-        error("Bounds error") # TODO: Make this more standard
+        error("Bounds error") # This should be `throw(BoundsError())` but the type inference is so fragile that it doesn't work. Needs investigation. / Jonatan 2023-06-08
     end
 end
 
 
-## 2D Specific implementations to avoid instability
-## TODO: Should really be solved by fixing the general methods instead
+# 2D Specific implementations to avoid type instability
+# TBD: Can this be solved by fixing the general methods instead?
 
 
 ## x-direction