diff test/SbpOperators/boundaryops/boundary_operator_test.jl @ 1099:05a25a5063bb refactor/sbpoperators/inflation

Try to remove volume_operator and boundary_operator methods
author Jonatan Werpers <jonatan@werpers.com>
date Mon, 21 Mar 2022 12:51:39 +0100
parents 1ba8a398af9c
children 157a78959e5d
line wrap: on
line diff
--- a/test/SbpOperators/boundaryops/boundary_operator_test.jl	Mon Mar 21 10:04:15 2022 +0100
+++ b/test/SbpOperators/boundaryops/boundary_operator_test.jl	Mon Mar 21 12:51:39 2022 +0100
@@ -6,7 +6,8 @@
 using Sbplib.RegionIndices
 import Sbplib.SbpOperators.Stencil
 import Sbplib.SbpOperators.BoundaryOperator
-import Sbplib.SbpOperators.boundary_operator
+
+# TODO: What should happen to all the commented tests? Deleted? Replicated for user code?
 
 @testset "BoundaryOperator" begin
     closure_stencil = Stencil((0,2), (2.,1.,3.))
@@ -14,26 +15,26 @@
     g_2D = EquidistantGrid((11,15), (0.0, 0.0), (1.0,1.0))
 
     @testset "Constructors" begin
-        @testset "1D" begin
+        @testset "1D" begin # TODO: Remove these testsets
             op_l = BoundaryOperator{Lower}(closure_stencil,size(g_1D)[1])
             @test op_l == BoundaryOperator(g_1D,closure_stencil,Lower())
-            @test op_l == boundary_operator(g_1D,closure_stencil,CartesianBoundary{1,Lower}())
             @test op_l isa LazyTensor{T,0,1} where T
 
-            op_r = BoundaryOperator{Upper}(closure_stencil,size(g_1D)[1])
+            op_r = BoundaryOperator{Upper}(closure_stencil,size(g_1D)[1]) # TBD: Is this constructor really needed? looks weird!
             @test op_r == BoundaryOperator(g_1D,closure_stencil,Upper())
-            @test op_r == boundary_operator(g_1D,closure_stencil,CartesianBoundary{1,Upper}())
             @test op_r isa LazyTensor{T,0,1} where T
         end
 
-        @testset "2D" begin
-            e_w = boundary_operator(g_2D,closure_stencil,CartesianBoundary{1,Upper}())
-            @test e_w isa InflatedLazyTensor
-            @test e_w isa LazyTensor{T,1,2} where T
-        end
+        # @testset "2D" begin
+        #     e_w = boundary_operator(g_2D,closure_stencil,CartesianBoundary{1,Upper}())
+        #     @test e_w isa InflatedLazyTensor
+        #     @test e_w isa LazyTensor{T,1,2} where T
+        # end
     end
-    op_l, op_r = boundary_operator.(Ref(g_1D), Ref(closure_stencil), boundary_identifiers(g_1D))
-    op_w, op_e, op_s, op_n = boundary_operator.(Ref(g_2D), Ref(closure_stencil), boundary_identifiers(g_2D))
+
+    op_l = BoundaryOperator(g_1D, closure_stencil, Lower())
+    op_r = BoundaryOperator(g_1D, closure_stencil, Upper())
+    # op_w, op_e, op_s, op_n = boundary_operator.(Ref(g_2D), Ref(closure_stencil), boundary_identifiers(g_2D))
 
     @testset "Sizes" begin
         @testset "1D" begin
@@ -44,17 +45,17 @@
             @test range_size(op_r) == ()
         end
 
-        @testset "2D" begin
-            @test domain_size(op_w) == (11,15)
-            @test domain_size(op_e) == (11,15)
-            @test domain_size(op_s) == (11,15)
-            @test domain_size(op_n) == (11,15)
+        # @testset "2D" begin
+        #     @test domain_size(op_w) == (11,15)
+        #     @test domain_size(op_e) == (11,15)
+        #     @test domain_size(op_s) == (11,15)
+        #     @test domain_size(op_n) == (11,15)
 
-            @test range_size(op_w) == (15,)
-            @test range_size(op_e) == (15,)
-            @test range_size(op_s) == (11,)
-            @test range_size(op_n) == (11,)
-        end
+        #     @test range_size(op_w) == (15,)
+        #     @test range_size(op_e) == (15,)
+        #     @test range_size(op_s) == (11,)
+        #     @test range_size(op_n) == (11,)
+        # end
     end
 
     @testset "Application" begin
@@ -76,43 +77,43 @@
             @test (op_l'*u)[11] isa ComplexF64
         end
 
-        @testset "2D" begin
-            v = rand(size(g_2D)...)
-            u = fill(3.124)
-            @test op_w*v ≈ 2*v[1,:] + v[2,:] + 3*v[3,:] rtol = 1e-14
-            @test op_e*v ≈ 2*v[end,:] + v[end-1,:] + 3*v[end-2,:] rtol = 1e-14
-            @test op_s*v ≈ 2*v[:,1] + v[:,2] + 3*v[:,3] rtol = 1e-14
-            @test op_n*v ≈ 2*v[:,end] + v[:,end-1] + 3*v[:,end-2] rtol = 1e-14
+       #  @testset "2D" begin
+       #      v = rand(size(g_2D)...)
+       #      u = fill(3.124)
+       #      @test op_w*v ≈ 2*v[1,:] + v[2,:] + 3*v[3,:] rtol = 1e-14
+       #      @test op_e*v ≈ 2*v[end,:] + v[end-1,:] + 3*v[end-2,:] rtol = 1e-14
+       #      @test op_s*v ≈ 2*v[:,1] + v[:,2] + 3*v[:,3] rtol = 1e-14
+       #      @test op_n*v ≈ 2*v[:,end] + v[:,end-1] + 3*v[:,end-2] rtol = 1e-14
 
 
-            g_x = rand(size(g_2D)[1])
-            g_y = rand(size(g_2D)[2])
+       #      g_x = rand(size(g_2D)[1])
+       #      g_y = rand(size(g_2D)[2])
 
-            G_w = zeros(Float64, size(g_2D)...)
-            G_w[1,:] = 2*g_y
-            G_w[2,:] = g_y
-            G_w[3,:] = 3*g_y
+       #      G_w = zeros(Float64, size(g_2D)...)
+       #      G_w[1,:] = 2*g_y
+       #      G_w[2,:] = g_y
+       #      G_w[3,:] = 3*g_y
 
-            G_e = zeros(Float64, size(g_2D)...)
-            G_e[end,:] = 2*g_y
-            G_e[end-1,:] = g_y
-            G_e[end-2,:] = 3*g_y
+       #      G_e = zeros(Float64, size(g_2D)...)
+       #      G_e[end,:] = 2*g_y
+       #      G_e[end-1,:] = g_y
+       #      G_e[end-2,:] = 3*g_y
 
-            G_s = zeros(Float64, size(g_2D)...)
-            G_s[:,1] = 2*g_x
-            G_s[:,2] = g_x
-            G_s[:,3] = 3*g_x
+       #      G_s = zeros(Float64, size(g_2D)...)
+       #      G_s[:,1] = 2*g_x
+       #      G_s[:,2] = g_x
+       #      G_s[:,3] = 3*g_x
 
-            G_n = zeros(Float64, size(g_2D)...)
-            G_n[:,end] = 2*g_x
-            G_n[:,end-1] = g_x
-            G_n[:,end-2] = 3*g_x
+       #      G_n = zeros(Float64, size(g_2D)...)
+       #      G_n[:,end] = 2*g_x
+       #      G_n[:,end-1] = g_x
+       #      G_n[:,end-2] = 3*g_x
 
-            @test op_w'*g_y == G_w
-            @test op_e'*g_y == G_e
-            @test op_s'*g_x == G_s
-            @test op_n'*g_x == G_n
-       end
+       #      @test op_w'*g_y == G_w
+       #      @test op_e'*g_y == G_e
+       #      @test op_s'*g_x == G_s
+       #      @test op_n'*g_x == G_n
+       # end
 
        @testset "Regions" begin
             u = fill(3.124)