Mercurial > repos > public > sbplib_julia

comparison Notes.md @ 939:d8da3a1060b7 feature/variable_derivatives

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add note about where to put Regions
author Jonatan Werpers <jonatan@werpers.com>
date Wed, 09 Mar 2022 10:14:16 +0100
parents eb03bda76bae
children f885e1de6dc4
comparison
equal deleted inserted replaced
937:025a506ca2fa 939:d8da3a1060b7
146 Seems better unless there is some specific reason to use the type instead of the value. 146 Seems better unless there is some specific reason to use the type instead of the value.
147 - [ ] How do we handle mixes of periodic and non-periodic grids? Seems it should be supported on the grid level and on the 1d operator level. Between there it should be transparent. 147 - [ ] How do we handle mixes of periodic and non-periodic grids? Seems it should be supported on the grid level and on the 1d operator level. Between there it should be transparent.
148 - [ ] Can we have a trait to tell if a TensorMapping is transposable? 148 - [ ] Can we have a trait to tell if a TensorMapping is transposable?
149 - [ ] Is it ok to have "Constructors" for abstract types which create subtypes? For example a Grids() functions that gives different kind of grids based on input? 149 - [ ] Is it ok to have "Constructors" for abstract types which create subtypes? For example a Grids() functions that gives different kind of grids based on input?
150 150
151 ## Identifiers for regions
152 The identifiers (`Upper`, `Lower`, `Interior`) used for region indecies should probabily be included in the grid module. This allows new grid types to come with their own regions.
153
151 ## Regions and tensormappings 154 ## Regions and tensormappings
152 - [ ] Use a trait to indicate if a TensorMapping uses indices with regions. 155 - [ ] Use a trait to indicate if a TensorMapping uses indices with regions.
153 The default should be that they do NOT. 156 The default should be that they do NOT.
154 - [ ] What to name this trait? Can we call it IndexStyle but not export it to avoid conflicts with Base.IndexStyle? 157 - [ ] What to name this trait? Can we call it IndexStyle but not export it to avoid conflicts with Base.IndexStyle?
155 - [ ] Figure out repeated application of regioned TensorMappings. Maybe an instance of a tensor mapping needs to know the exact size of the range and domain for this to work? 158 - [ ] Figure out repeated application of regioned TensorMappings. Maybe an instance of a tensor mapping needs to know the exact size of the range and domain for this to work?