Mercurial > repos > public > sbplib_julia

comparison src/SbpOperators/volumeops/volume_operator.jl @ 810:a4d7ca5de3c6 refactor/sbp_operators_method_signatures

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Review: Suggested changes to volume_operator.jl
author Vidar Stiernström <vidar.stiernstrom@it.uu.se>
date Mon, 20 Sep 2021 20:36:20 +0200
parents b6c0963100cd
children ae28f1d7ef5e
comparison
equal deleted inserted replaced
807:1fc6c4daec44 810:a4d7ca5de3c6
7 corresponding `VolumeOperator` tensor mapping is returned. When `Dim>1`, the 7 corresponding `VolumeOperator` tensor mapping is returned. When `Dim>1`, the
8 returned operator is the appropriate outer product of a one-dimensional 8 returned operator is the appropriate outer product of a one-dimensional
9 operators and `IdentityMapping`s, e.g for `Dim=3` the volume operator in the 9 operators and `IdentityMapping`s, e.g for `Dim=3` the volume operator in the
10 y-direction is `I⊗op⊗I`. 10 y-direction is `I⊗op⊗I`.
11 """ 11 """
12 # Review: The type parameters Dim, T in the signature can be removed,
13 # by the following changes:
14 # one_d_grids = restrict.(Ref(grid), Tuple(1:Dim)) -->
15 # one_d_grids = restrict.(Ref(grid), Tuple(1:dimension(grid)))
16 # and
17 # Is = IdentityMapping{T}.(size.(one_d_grids)) -->
18 # Is = IdentityMapping{eltype(grid)}.(size.(one_d_grids))
12 function volume_operator(grid::EquidistantGrid{Dim,T}, inner_stencil, closure_stencils, parity, direction) where {Dim,T} 19 function volume_operator(grid::EquidistantGrid{Dim,T}, inner_stencil, closure_stencils, parity, direction) where {Dim,T}
13 #TODO: Check that direction <= Dim? 20 #TODO: Check that direction <= Dim?
14 21
15 # Create 1D volume operator in along coordinate direction 22 # Create 1D volume operator in along coordinate direction
16 op = VolumeOperator(restrict(grid, direction), inner_stencil, closure_stencils, parity) 23 op = VolumeOperator(restrict(grid, direction), inner_stencil, closure_stencils, parity)