Mercurial > repos > public > sbplib_julia

comparison Notes.md @ 1222:5f677cd6f0b6 refactor/grids

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Start refactoring
author Jonatan Werpers <jonatan@werpers.com>
date Sat, 18 Feb 2023 11:37:35 +0100
parents 396278072f18
children a8fa8c1137cc
comparison
equal deleted inserted replaced
1221:b3b4d29b46c3 1222:5f677cd6f0b6
146 - [ ] Is it ok to have "Constructors" for abstract types which create subtypes? For example a Grids() functions that gives different kind of grids based on input? 146 - [ ] Is it ok to have "Constructors" for abstract types which create subtypes? For example a Grids() functions that gives different kind of grids based on input?
147 - [ ] Figure out how to treat the borrowing parameters of operators. Include in into the struct? Expose via function dispatched on the operator type and grid? 147 - [ ] Figure out how to treat the borrowing parameters of operators. Include in into the struct? Expose via function dispatched on the operator type and grid?
148 148
149 ## Identifiers for regions 149 ## Identifiers for regions
150 The identifiers (`Upper`, `Lower`, `Interior`) used for region indecies should probabily be included in the grid module. This allows new grid types to come with their own regions. 150 The identifiers (`Upper`, `Lower`, `Interior`) used for region indecies should probabily be included in the grid module. This allows new grid types to come with their own regions.
151 We implement this by refactoring RegionIndices to be agnostic to the region types and then moving the actual types to Grids.
151 152
152 ## Regions and tensormappings 153 ## Regions and tensormappings
153 - [ ] Use a trait to indicate if a LazyTensor uses indices with regions. 154 - [ ] Use a trait to indicate if a LazyTensor uses indices with regions.
154 The default should be that they do NOT. 155 The default should be that they do NOT.
155 - [ ] What to name this trait? Can we call it IndexStyle but not export it to avoid conflicts with Base.IndexStyle? 156 - [ ] What to name this trait? Can we call it IndexStyle but not export it to avoid conflicts with Base.IndexStyle?