Mercurial > repos > public > sbplib_julia

comparison src/Grids/geometry.jl @ 2069:15f27fea9929 feature/grids/geometry_functions

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove review comments about output types.
author Jonatan Werpers <jonatan@werpers.com>
date Tue, 17 Feb 2026 20:15:37 +0100
parents 00b274a118e0
children c68fa6c74477
comparison
equal deleted inserted replaced
2068:8266acd4113f 2069:15f27fea9929
6 end 6 end
7 7
8 8
9 # REVIEW: 9 # REVIEW:
10 # 1. Explain the parametrization, i.e., l(1) = p + s*t 10 # 1. Explain the parametrization, i.e., l(1) = p + s*t
11 # 2. Now, if p and t are ints, l(1) returns an int
12 # while l(0.5) returns a float. Is this intended/desirable?
13 """ 11 """
14 Line(p,t) 12 Line(p,t)
15 13
16 A line, as a callable object, starting at `p` with tangent `t`. 14 A line, as a callable object, starting at `p` with tangent `t`.
17 15
53 end 51 end
54 52
55 53
56 # REVIEW: 54 # REVIEW:
57 # 1. Explain the parametrization. 55 # 1. Explain the parametrization.
58 # 2. Now, if a and b are ints, l(1) returns an int
59 # while l(0.5) returns a float. Is this intended/desirable?
60 # 3. Do we want s in [0, 1]? Currently the line segment 56 # 3. Do we want s in [0, 1]? Currently the line segment
61 # can return values "outside" of the interval [a,b]. 57 # can return values "outside" of the interval [a,b].
62 """ 58 """
63 LineSegment(a,b) 59 LineSegment(a,b)
64 60